Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plantuml rendering shows blank screen on error #97

Open
abulka opened this issue Jul 1, 2021 · 1 comment
Open

plantuml rendering shows blank screen on error #97

abulka opened this issue Jul 1, 2021 · 1 comment
Labels
PlantUML Relating to PlantUML server rendering Priority-Medium Usability

Comments

@abulka
Copy link
Owner

abulka commented Jul 1, 2021

Should show error image instead, which at least gives an indication that there was an error and why. Or detect response 400 and display something meaningful

Example log file:

[Thu 10:35 am] [INFO] __main__ - 741 - image_url of UML http://www.plantuml.com/plantuml/png/Iyv9B2vMS5Ievb9GA4XCJoq6qhcf9HdvAOOQcborN5p9O0N1UOa5RfavgM6PgUL6Ba3LN4XocRa5EQaU9IK58Od5sM2JadCoK_DAu4O16QL5EKXQe0gHH4BpilFoo_CKGYeBKc4oQ9RQwEe27Sg5PfskReqTn3mk53D0gj6KSW40
[Thu 10:35 am] [INFO] common.gui_imageviewer - 155 - (2nd, image grabbing) Response from plant_uml_server status_code 400
[Thu 10:35 am] [ERROR] common.gui_imageviewer - 165 - Error getting plantuml IMAGE, (bad response 400)

image

@abulka
Copy link
Owner Author

abulka commented Jul 1, 2021

Caused by Pynsource creating a class with a space character Unknown Type from this syntax:

class SimpleHttpTask(Task):
    url = None
    method = "GET"
    client: requests.Session = requests.Session()

See issue #85

@abulka abulka added the PlantUML Relating to PlantUML server rendering label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PlantUML Relating to PlantUML server rendering Priority-Medium Usability
Projects
None yet
Development

No branches or pull requests

1 participant