Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle pending transaction notification correctly #7

Open
judgej opened this issue Nov 29, 2018 · 3 comments
Open

Handle pending transaction notification correctly #7

judgej opened this issue Nov 29, 2018 · 3 comments
Assignees
@judgej
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@judgej
Copy link
Member

judgej commented Nov 29, 2018

https://github.com/academe/omnipay-datatrans/blob/master/src/Message/AcceptNotification.php#L47

A pending transaction is returning as failed, because isPending() is not correctly set.
@judgej judgej added the bug Something isn't working label Nov 29, 2018
@judgej judgej self-assigned this Nov 29, 2018
@judgej
Copy link
Member Author

judgej commented Dec 2, 2018

Latest docs 9.3.14 is still a little ambiguous, so some examples of pending transactions is being sought.

https://admin.sandbox.datatrans.com/showcase/doc/Technical_Implementation_Guide.pdf

judgej added a commit that referenced this issue Dec 3, 2018
@judgej
Issue #7 partial
7654e30 
Check PayPal pending flag and set isPending() appropriaely.
@judgej
Copy link
Member Author

judgej commented Dec 3, 2018

Testing with PayPal, the pendingPayPal flag can be set in the response (to "yes") while the status is success. This doesn't hit the original issue use-case though.

@judgej
Copy link
Member Author

judgej commented Dec 3, 2018 •
edited
Loading

The original problem was with the PostFinance payment type, so may be something to follow up with them. PostFinance specifically deals with offline repeat payments. The Datatrans documentation does not list any special statuses returned by PostFinance.

@judgej judgej added the help wanted Extra attention is needed label Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judgej judgej

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judgej