Autocomplete endpoint only queries name, not labels

[skurzinz]

@sviatoplok noted that

Contrary to what the Web GUI "name or label" search box does, the autocomplete endpoint does not return entites with a label.

https://mpr.acdh.oeaw.ac.at/apis/entities/autocomplete/place/?term=bodenbach&q=bodenbach&_type=query only returns external GeoNames entities

https://mpr.acdh.oeaw.ac.at/apis/entities/autocomplete/place/?term=podmokly&q=podmokly&_type=query returns the entity that is already stored in the MPR and has the label "Bodenbach".

Expected behaviour:

https://mpr.acdh.oeaw.ac.at/apis/entities/autocomplete/place/?term=bodenbach&q=bodenbach&_type=query should return https://mpr.acdh.oeaw.ac.at/entity/7431

As the "name or label" search box already shows this behaviour I suspect this could be easily achieved.

[sviatoplok]

The same happens with:

Places

• Italien
• Russland
• Serbien
• Wien
• Vorarlberg

Persons

• Leth, Karl

[sviatoplok]

In the case of persons, d-nb database entries are being returned

[sviatoplok]

The problem also occurs when linking

• Kaiserlich-Königliche Staats-Oberrealschule (Laibach)

[sennierer]

yes, that should be easy to fix. we are on it.

[sviatoplok]

bitte melden, wenn fertig, dann kann ich mit dem copypasten aufhören

[skurzinz]

👍 Am 13.07.2022 10:41 schrieb Matthias Schlögl ***@***.***>: yes, that should be easy to fix. we are on it. — Reply to this email directly, view it on GitHub<#338 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI5U6VIWEWLMZA4Y6I3PRVDVTZ6MBANCNFSM525E4UUA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[sviatoplok]

Also in the relations UI the entity search does not find labels.
"Laibach" finds the geonames entries called Laibach, but not the db entry called Ljubljana.

[sviatoplok]

Now it also happened with an institution:

Handelsministerium

[sviatoplok]

Persenbeug

[sviatoplok]

Deutsches Reich
Wien

[sviatoplok]

Bregenz

[sviatoplok]

Interessant auch UNGARN:

die URL hat die ID drin, die URI ist aber anders und eine weitere MPR-URI gibt es nicht:

++++++++++++++++++++++

[sviatoplok]

Interessant auch UNGARN:

die URL hat die ID drin, die URI ist aber anders und eine weitere MPR-URI gibt es nicht:

++++++++++++++++++++++

detto Arbeitsministerium, Eisenbahnministerium

[sviatoplok]

Derselbe Ärger wegen falscher URLs mit

Kärnten
[Generaldirektion des Grundsteuerkatasters]
[Finanzlandesdirektion in Graz](

[sviatoplok]

ebenso Statthalterei Prag

[sviatoplok]

Abgeordnetenhaus

Sozialdemokratische Arbeiterpartei

[richardhadden]

Should be fixed by changing APIS_ENTITIES.<entity>.search in settings/base.py. Labels are a related entity, so should be added as label__label, e.g.

 "Place": {
        "merge": True,
        "search": ["name", "label__label"],
         ...
 }

This has been done for settings/base.py in apis-devops repository: acdh-oeaw/apis-devops#1