Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add German verbose_names to inherited entity classes #69

Open
koeaw opened this issue Dec 4, 2024 · 0 comments · May be fixed by #71
Open

Add German verbose_names to inherited entity classes #69

koeaw opened this issue Dec 4, 2024 · 0 comments · May be fixed by #71
Labels
app-entities Anything to do with the model classes central to the ontology enhancement New feature or request UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface)

Comments

@koeaw
Copy link
Collaborator

koeaw commented Dec 4, 2024 •
edited
Loading

Person, Place, Group entity classes use the English field names for verbose names in the backend UI, which leads to a weird mix of German and English wordings for fields.

-> Set verbose_names for their default fields explicitly.
@koeaw koeaw added enhancement New feature or request app-entities Anything to do with the model classes central to the ontology UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface) labels Dec 4, 2024
@koeaw koeaw mentioned this issue Dec 9, 2024
Closed
koeaw added a commit that referenced this issue Dec 9, 2024
@koeaw
feat(models): add field verbose_names
03cfce5 
Add `__init__` methods for `Person`, `Place`,
`Group` classes to add German `verbose_names`
to inherited fields.

Closes: #69
@koeaw koeaw linked a pull request Dec 9, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-entities Anything to do with the model classes central to the ontology enhancement New feature or request UI-UX Appearance, coherence, usability of user-facing parts (frontend, user interface)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(models): add field verbose_names acdh-oeaw/apis-instance-tbf
1 participant
@koeaw