Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for support for private registries #419

Closed
casanova-21 opened this issue May 11, 2023 · 9 comments
Closed

Request for support for private registries #419

casanova-21 opened this issue May 11, 2023 · 9 comments
Labels
duplicate This issue or pull request already exists feature request New feature or request to improve the current logic

Comments

@casanova-21
Copy link

Description:
My customer, Wells Fargo, is requesting that this Action be modified to provide support for publishing and downloading artifacts from a private repository. They're working on moving to GHEC, and have indicated that this is a critical blocker for them to be able to use this Action.

Justification:
Customer will not be allowing packages to be published or pulled to a public repository. It must all be internal.

Are you willing to submit a PR?
I'm willing but lack the developer chops to do this.

@casanova-21 casanova-21 added feature request New feature or request to improve the current logic needs triage labels May 11, 2023
@IvanZosimov
Copy link
Contributor

Hi, @casanova-21 thanks for the feature request! We are going to take a look at it and get back to you with updates.

@casanova-21
Copy link
Author

Thank you very much @IvanZosimov!

@nikolai-laevskii
Copy link
Contributor

If your team moves on to GHEC, it might be safe to assume that you'll be using Github Packages. We have this case covered already: https://docs.github.com/en/packages/learn-github-packages/introduction-to-github-packages#authenticating-to-github-packages

Could you please provide feedback whether it suits your current needs? And if not, elaborate further on your request. Thank you!

@casanova-21
Copy link
Author

Hi @nikolai-laevskii 👋 Thank you for the response. I can confirm that my customer won't be using Packages and will continue to use their private registry, Artifactory, after migrating to GHEC. So I will still need to request the functionality be added to this Action.

@casanova-21
Copy link
Author

Hello! Customer is again asking for an update on this one. Is this something that will be able to be prioritized and implemented?

@IvanZosimov
Copy link
Contributor

Hi, @casanova-21 👋 ! Thanks for pushing this issue forward, nevertheless, some time is required to internally discuss the issue. We understand that it's very important for you and your customer, so we will try to do it quickly and give you an update, but to do this, we need more information.

I'd like to ask you whether your customer tried to set up a custom NuGet feed using this examples: https://github.com/actions/setup-dotnet/blob/main/README.md#setting-up-authentication-for-nuget-feeds ?
If it was done and it didn't work out, what was the problem?

Also, it's worth mentioning that publishing and getting NuGet packages from the private feed can be configured manually. You can check the information with examples: #415 (comment) and #167 (comment)

@IvanZosimov IvanZosimov self-assigned this Jun 8, 2023
@casanova-21
Copy link
Author

@IvanZosimov Apologies for the delay in getting back to you on this. To answer your questions, no, to my knowledge our customer has not attempted to set up a custom NuGet feed. Looking at that documentation, it is intended to be used with GitHub Packages, Azure Artifacts, and nuget.org. I had mentioned above that my customer is adamant about using their internal Artifactory platform for the package registry. I just want to confirm that I'm not misunderstanding anything about the existing functionality of the Action that would give them a path forward to use Artifactory, or if adding new functionality to the Action is the only way to achieve what they want. Thank you!

@IvanZosimov
Copy link
Contributor

Hi, @casanova-21 👋 In my previous comment I just wanted to say that your customer can try to configure authentication to the their Artifactory using examples from this guide: https://github.com/actions/setup-dotnet/blob/main/README.md#setting-up-authentication-for-nuget-feeds and also it's possible to authenticate manually, using examples from these comments: #415 (comment), #167 (comment)

@IvanZosimov IvanZosimov removed their assignment Jul 3, 2023
@IvanZosimov IvanZosimov added duplicate This issue or pull request already exists and removed needs eyes labels Sep 1, 2023
@IvanZosimov
Copy link
Contributor

Hi, @casanova-21 👋 I'm going to close this issue now as a duplicate of the #415. Still, you can track the progress there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants