Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common CMake preset requires ccache #3537

Open
stephenswat opened this issue Aug 22, 2024 · 6 comments
Open

common CMake preset requires ccache #3537

stephenswat opened this issue Aug 22, 2024 · 6 comments
Labels
Infrastructure Changes to build tools, continous integration, ... Stale

Comments

@stephenswat
Copy link
Member

I've been trying to use the github-ci preset as a sort of "build everything, so if it works locally it will most likely pass the CI" build. However, I have noticed that this sets ccache as the compiler launcher. Makes sense, of course, for a CI preset. However, it appears that ccache is required in the common preset, from which all others inherit.

In my mind, it would be useful to have an "everything" preset for local builds, which does not require ccache. Given the multiple inheritance that CMake presets allow, I'd suggest we could have a ccache preset which sets ccache, and then common could have the launcher flag removed. We could then also have some kind of everything flag which would just build everything, like the ACTS_BUILD_EVERYTHING flag used to do.

Looking to see if anyone has any opinions on this so we can come to a nice compromise that everyone agrees with.

@stephenswat
Copy link
Member Author

For the record, my current workaround for local builds is this:

cmake -B build -S . --preset github-ci -DCMAKE_CXX_COMPILER_LAUNCHER=""

@paulgessinger
Copy link
Member

paulgessinger commented Aug 22, 2024

@andiwand

Also, fyi, you can add a CMakeUserPresets.json with custom presets that can extend the original ones.

@andiwand
Copy link
Contributor

Sounds good to me. I put it there because we (or maybe I) use it everywhere. In the CI and local (since I have multiple ACTS build folder).

I didn't know that there is multiple inheritance which felt like a limitations to me. If you have a nice separation in mind I am happy to review!

@paulgessinger
Copy link
Member

I think the CI mode also enables -Werror, which you might not want for local development.

Copy link

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@github-actions github-actions bot added the Stale label Sep 21, 2024
@AJPfleger AJPfleger added the Infrastructure Changes to build tools, continous integration, ... label Nov 21, 2024
@github-actions github-actions bot removed the Stale label Nov 21, 2024
Copy link

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@github-actions github-actions bot added the Stale label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ... Stale
Projects
None yet
Development

No branches or pull requests

4 participants