Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: some bounding box test cases fail on macOS ci #3847

Open
AJPfleger opened this issue Nov 11, 2024 · 1 comment
Open

test: some bounding box test cases fail on macOS ci #3847

AJPfleger opened this issue Nov 11, 2024 · 1 comment
Labels
Impact - Minor Nuissance bug and/or affects only a single module Stale

Comments

@AJPfleger
Copy link
Contributor

Many cases were disabled in Tests/UnitTests/Core/Utilities/BoundingBoxTest.cpp because of fails with double precision. After rechecking all tests in

The disabled tests are:

    // upper bound is exclusive - temporarily removed, fails macOS ci
    // ray = {{-2, 1}, {1, 0}};
    // BOOST_CHECK(!bb.intersect(ray));

    // upper bound is exclusive - temporarily removed, fails macOS ci
    // ray = {{2, 1}, {-1, 0}};
    // BOOST_CHECK(!bb.intersect(ray));

    // right on slab - temporarily removed, fails macOS ci
    // ray3 = {{0, 1, -2}, {0, 0, 1}};
    // BOOST_CHECK(!bb3.intersect(ray3));

The reason is not clear yet and should be investigated.

@AJPfleger AJPfleger added the Impact - Minor Nuissance bug and/or affects only a single module label Nov 21, 2024
Copy link

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@github-actions github-actions bot added the Stale label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact - Minor Nuissance bug and/or affects only a single module Stale
Projects
None yet
Development

No branches or pull requests

1 participant