Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of fresh image fails due to ue4-cli failure due to Conan breaking changes #305

Closed
mhenderson-t2 opened this issue Mar 14, 2023 · 3 comments · Fixed by #306
Closed

Comments

@mhenderson-t2
Copy link

Output of the ue4-docker info command:

ue4-docker version:         0.0.106
Operating system:           Windows Server 2022 Datacenter (Build 20348.1547)
Docker daemon version:      20.10.9
NVIDIA Docker supported:    No
Maximum image size:         400GB
Available disk space:       435.68 GiB
Total system memory:        94.48 GiB physical, 13.5 GiB virtual
CPU:                        24 physical, 48 logical (Intel64 Family 6 Model 106 Stepping 6, GenuineIntel)

Additional details:

  • Are you accessing the network through a proxy server? No

Currently it's impossible to use these scripts/containers as provided due to a breaking change in the Conan package (conan-io/conan#12000 (comment))

Crash
Step 13/24 : RUN ue4 setroot C:\UnrealEngine && echo. && echo.RUN directive complete. Docker will now commit the filesystem layer to disk. && echo.Note that for large filesystem layers this can take quite some time. && echo.Performing filesystem layer commit... && echo.
 ---> Running in 3babf2fd9cc3
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Python311\Scripts\ue4.exe\__main__.py", line 7, in <module>
  File "C:\Python311\Lib\site-packages\ue4cli\cli.py", line 206, in main
    plugins = PluginManager.getPlugins()
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\ue4cli\PluginManager.py", line 16, in getPlugins
    plugins = {
              ^
  File "C:\Python311\Lib\site-packages\ue4cli\PluginManager.py", line 17, in <dictcomp>
    entry_point.name: entry_point.load()
                      ^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\pkg_resources\__init__.py", line 2471, in load
    return self.resolve()
           ^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\pkg_resources\__init__.py", line 2477, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\conan_ue4cli\__init__.py", line 1, in <module>
    from .descriptor import __PLUGIN_DESCRIPTOR__
  File "C:\Python311\Lib\site-packages\conan_ue4cli\descriptor.py", line 1, in <module>
    from .main import main
  File "C:\Python311\Lib\site-packages\conan_ue4cli\main.py", line 1, in <module>
    from .commands import boilerplate, build, generate, precompute, sources, update
  File "C:\Python311\Lib\site-packages\conan_ue4cli\commands\__init__.py", line 1, in <module>
    from .boilerplate import boilerplate
  File "C:\Python311\Lib\site-packages\conan_ue4cli\commands\boilerplate.py", line 1, in <module>
    from ..common import ConanTools
  File "C:\Python311\Lib\site-packages\conan_ue4cli\common\__init__.py", line 2, in <module>
    from .ConanTools import ConanTools
  File "C:\Python311\Lib\site-packages\conan_ue4cli\common\ConanTools.py", line 1, in <module>
    from conans import tools
ImportError: cannot import name 'tools' from 'conans' (C:\Python311\Lib\site-packages\conans\__init__.py)

I have submitted a PR to pin the version of conan (adamrehn/conan-ue4cli#24), this issue will hopefully surface for anyone else who is running into the same issue at the moment.

@slonopotamus
Copy link
Collaborator

Currently it's impossible to use these scripts/containers as provided

You can use ue4-docker build --target=minimal and produce an image without ue4-cli/Conan.

@slonopotamus
Copy link
Collaborator

@adamrehn just in case: I neither have commit access to conan-ue4cli nor have any interest in Conan in general, so am going to absolutely nothing about this issue.

There are also some open issues about conan-ue4cli not supporting UE5 at all.

I am personally not sure that ue4-full should exist at all. Users can add whatever they want on top of our (or Epic official) images. Also, given that Epics now publish official images, the usage of ue4-docker will definitely slowly shift away from "build your own image" to "use official one". And in the latter case, there is no ue4-full anyway.

@isqrd
Copy link
Contributor

isqrd commented Mar 17, 2023

We are currently using the full image to do some of our builds, and I ran into this building new 5.1.1 images for both linux and windows.

I just created a pull request to fix the issue #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants