From 9e4b446a6d29be42806bb529d7a10db6733cb019 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Zl=C3=A1mal?= Date: Fri, 4 Dec 2020 09:16:12 -0600 Subject: [PATCH] Eslint config: disable 'relay/graphql-naming' rule This rule is no longer accurate, see: https://github.com/facebook/relay/commit/ff1c10bc6595f3715f29660b46f779e000be9c70 We might (partially) revert this commit after this PR gets resolved: https://github.com/relayjs/eslint-plugin-relay/issues/107 --- src/eslint-config-adeira/CHANGELOG.md | 2 ++ .../__tests__/__snapshots__/index.test.js.snap | 2 +- src/eslint-config-adeira/ourRules.js | 2 +- src/ya-comiste-react-native/.eslintrc.js | 1 - 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/eslint-config-adeira/CHANGELOG.md b/src/eslint-config-adeira/CHANGELOG.md index 846d650097..1027e27354 100644 --- a/src/eslint-config-adeira/CHANGELOG.md +++ b/src/eslint-config-adeira/CHANGELOG.md @@ -1,5 +1,7 @@ # Unreleased +- Disabled rule `relay/graphql-naming` which is no longer accurate. We might enable it later again once this issue gets resolved: https://github.com/relayjs/eslint-plugin-relay/issues/107 + # 4.1.0 - Enable [`node/process-exit-as-throw`](https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/process-exit-as-throw.md) rule. This is potentially breaking, however, the impact should be minimal and the migration simple. Let us know in case it caused troubles, please. diff --git a/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap b/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap index 94f7f93501..ce372bc40d 100644 --- a/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap +++ b/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap @@ -859,7 +859,7 @@ Object { "react/void-dom-elements-no-children": 2, "relay/compat-uses-vars": 0, "relay/generated-flow-types": 2, - "relay/graphql-naming": 2, + "relay/graphql-naming": 0, "relay/graphql-syntax": 2, "relay/hook-required-argument": 2, "relay/must-colocate-fragment-spreads": 2, diff --git a/src/eslint-config-adeira/ourRules.js b/src/eslint-config-adeira/ourRules.js index 5cc5b2d7c5..a6b5f2be30 100644 --- a/src/eslint-config-adeira/ourRules.js +++ b/src/eslint-config-adeira/ourRules.js @@ -533,7 +533,7 @@ module.exports = ({ // Relay (https://github.com/relayjs/eslint-plugin-relay) 'relay/compat-uses-vars': OFF, // we do not use Relay Compat 'relay/generated-flow-types': ERROR, - 'relay/graphql-naming': ERROR, + 'relay/graphql-naming': OFF, // no longer needed, see: https://github.com/facebook/relay/commit/ff1c10bc6595f3715f29660b46f779e000be9c70 'relay/graphql-syntax': ERROR, 'relay/hook-required-argument': ERROR, 'relay/must-colocate-fragment-spreads': ERROR, diff --git a/src/ya-comiste-react-native/.eslintrc.js b/src/ya-comiste-react-native/.eslintrc.js index e2d2875228..32bb46c20b 100644 --- a/src/ya-comiste-react-native/.eslintrc.js +++ b/src/ya-comiste-react-native/.eslintrc.js @@ -10,6 +10,5 @@ module.exports = { rules: { // TODO: use @adeira/relay 'no-restricted-imports': OFF, - 'relay/graphql-naming': OFF, }, };