Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to test the provided player with the lts? #13

Open
cars10 opened this issue Oct 15, 2021 · 2 comments
Open

How to test the provided player with the lts? #13

cars10 opened this issue Oct 15, 2021 · 2 comments

Comments

@cars10
Copy link

cars10 commented Oct 15, 2021

We are currently trying to setup the LMS Testsuite. It would be nice if you could simply test the provided player with the lts to have a working starting point for implementing your own lms.custom.js to test your own lms.

Right now the provided example .env files in the respective README.md of player and lts are quite different and even use different names and terminology for what is (supposably) the same thing.

What i would like to see is some kind of "unification" of both examples so users can simply copy/paste both .env files, start the player and run the lts against it.

Is this possible or am i missing something here?

@brianjmiller
Copy link
Collaborator

Note that the lts/.env file only has 1 field that is actually expected by the automated test suite, and that is a pointer to the script that is used. The other values in there are all related specifically to the customized implementation. So the names could be better, but in general for LMSs not using specifically the prototype player the values they need and/or expect could be named differently or would be different than the ones expected by the provided script.

@cars10
Copy link
Author

cars10 commented Oct 15, 2021

Note that the lts/.env file only has 1 field that is actually expected by the automated test suite, and that is a pointer to the script that is used. The other values in there are all related specifically to the customized implementation.

Sure, i understand that. But i guess that the provided default/example script for the lts (lms.catapult-player.js) is expected to work with the catapult player. So it would be nice if there was a quick way of actually using that to run agains the provided player just to have a good starting point and not having to do days of trial&error just to get a running example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants