LTS: specify limit when loading statements

[cars10]

Hi,

we use a fairly low default limit of 5 statements per query if you do not specify a limit. This leads to issues with some tests in the LTS, the first one being https://github.com/adlnet/CATAPULT/blob/main/lts/__tests__/runtime.js#L95 because it expects a result with at least 6 statements on one page.

If a test expects more then one statement we should explicitly specify a limit to prevent this.

Edit: i think you are theoretically allowed to limit every request to just 1 result, regardless of what limit is provided by the client. So the better solution might be to follow the more property when we expect more then one statement?

[gavbaa]

Per the xAPI spec: https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Communication.md#partthree

The LRS can choose any size limit it sees fit, but needs to be configurable so as not to apply size limits during conformance testing. Of course, some size limits will still exist during conformance testing due to limitations of hardware, etc. but it is expected that these limits are sufficiently high so as not to affect the running of tests.

My reading of this is that it's completely on the LRS provider to make sure that they use limits sufficient for conformance testing, not for the test suite. In this case, it might be valuable for us to document what the LRS should be set to for a minimum limit as part of the LTS docs, but I don't believe we should do anything additional on the tests themselves.

[cars10]

but needs to be configurable so as not to apply size limits during conformance testing

This is a very valid point :) I agree that it simply comes down to missing documentation then.