Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False violation when Initialized is called in a batch of statements #19

Open
ysrn opened this issue Nov 3, 2021 · 0 comments
Open

False violation when Initialized is called in a batch of statements #19

ysrn opened this issue Nov 3, 2021 · 0 comments

Comments

@ysrn
Copy link

ysrn commented Nov 3, 2021

When sending a batch of statements (as in an array of more than one statement) with Initialized being the first of them, a false violation is produced: 9.3.0.0-4 - The "Initialized" verb MUST be the first statement (cmi5 allowed or defined).

The issue is in player/service/plugins/routes/lrs.js, which inspects each element of the statements array for: (! session.is_initialized && st.verb.id !== VERB_INITIALIZED_ID). Since is_initialized is only set later on, this code ends up outputting a false violation once it hits the second element of the array and beyond.

ysrn added a commit to ysrn/CATAPULT that referenced this issue Nov 16, 2021
Prevents a false violation from being thrown when initializing a session via a batch of statements adlnet#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant