feat: fragment block #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kptdobe
approved these changes
Feb 21, 2022
blocks/fragment/fragment.js
Outdated
| if (resp.ok) { | ||
| const main = document.createElement('main'); | ||
| main.innerHTML = await resp.text(); | ||
| const img = main.querySelector('img'); |
There was a problem hiding this comment.
Why only first image is lazy loaded ?
There was a problem hiding this comment.
Because the rest is set tolazy anyway. But to be honest, at this point it's irrelevant anyway, so I'll remove it again.
|
We should probably test (and add a check) for recursive fragment includes... |
|
|
It's still unclear what should happen with multiple sections, so I decided to remove multi-section support for now. We can add it back when we have a concrete use case. |
omprakashgupta1995
referenced
this pull request
in WWWPiramalFinanceCOM/piramalfinance
Jul 2, 2024
dpatil-magento
added a commit
to hlxsites/aem-boilerplate-commerce
that referenced
this pull request
Oct 7, 2024
* setup * update * update * update * update * update * update * update * update * update * ignore lint on cypress * exclude from edge delivery deployment * update * update * update * update * update * update * update * save screenshots on fail * test failure * update * update * run on local * update * update * update * update * update feedback * remove possible static waits * debug first run failures * update * fix flakyness * retry moode reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #65