New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apparently, an inexistent share link can also return a 403 #205

Open

dominique-pfister opened this issue Oct 25, 2021 · 1 comment

Labels

bug

Contributor

dominique-pfister commented Oct 25, 2021

In lines:

helix-onedrive-support/src/OneDrive.js

Lines 343 to 345 in d323bcb

    
           if (e.statusCode === 401) { 
        
             // an inexistant share returns 401, we prefer to just say it wasn't found 
        
             throw new StatusCodeError(e.message, 404, e.details);

one should also check for a 403: some tests with inexistent file names or paths indicate that this status code might also be used.

dominique-pfister added the bug label

Contributor Author

dominique-pfister commented Oct 25, 2021

related to https://github.com/adobe/helix-excel-indexer/issues/261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment