Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to support jdk repo and branch #92

Open
sophia-guo opened this issue Jun 30, 2021 · 4 comments
Open

Add option to support jdk repo and branch #92

sophia-guo opened this issue Jun 30, 2021 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Jun 30, 2021

Currently run-aqa run latest openjdk tests for all jdks. That is jdk8 for all hotspot jdk8. Similar to all other version and all openj9 jdk.

It would be nice if we add option to support jdk repo and branch so we can run each jdk's corresponding tests and the run-aqa tests can be part of openjdk repo's PR tests.

We could do this ether by passing the environment variable or adding the options. Adding the options would be more easy and clear. Similar to the draft PR #32

@sophia-guo sophia-guo added the good first issue Good for newcomers label Jun 30, 2021
@bhuva-v
Copy link

bhuva-v commented Oct 1, 2021

I'ld like to work on this. Thanks

@smlambert
Copy link
Contributor

Great @bhuva-v !

bhuva-v added a commit to bhuva-v/run-aqa that referenced this issue Oct 1, 2021
@smlambert
Copy link
Contributor

I will note that these are the instructions for generating the changes for index.js
https://github.com/actions/typescript-action#code-in-main
npm run build && npm run package

bhuva-v added a commit to bhuva-v/run-aqa that referenced this issue Oct 1, 2021
@bhuva-v
Copy link

bhuva-v commented Oct 1, 2021

npm run build && npm run package

npm run build && npm run pack

bhuva-v added a commit to bhuva-v/run-aqa that referenced this issue Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants