Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include @nx/devkit as a dependency #972

Open
isaacplmann opened this issue Aug 3, 2023 · 6 comments
Open

Include @nx/devkit as a dependency #972

isaacplmann opened this issue Aug 3, 2023 · 6 comments

Comments

@isaacplmann
Copy link

This plugin doesn't have an Nx version listed in the Nx Plugin Registry because the plugin doesn't include @nx/devkit as a dependency. Could you please release a version that fixes that?

Thanks,
Isaac (Nx Team)

@adrian-goe
Copy link
Owner

hey @isaacplmann I will do, but just to be sure, this goes into addDependenciesToPackageJson part as a dev dependency right?

@teaforchris
Copy link

I had a similar issue, I couldn't just run nx generate @ago-dev/nx-aws-cdk-v2:application myApp - I had to methodically retry and manually install several dependencies before it would generate the app:

@nx/devkit
@nx/jest
@nx/linter

@nubunto
Copy link

nubunto commented Dec 15, 2023

kinda unusable without this

@thoroc
Copy link

thoroc commented Apr 7, 2024

@isaacplmann could you answer the question? @adrian-goe might still be waiting for you.

@isaacplmann
Copy link
Author

isaacplmann commented Apr 9, 2024

The easiest solution is to add the packages to the dependencies in https://github.com/adrian-goe/nx-aws-cdk-v2/blob/main/packages/aws-cdk-v2/package.json

You can put them in the dependencies or peerDependencies. devDependencies won't require the users of your package to have those packages installed.

I think that function is another way of adding the packages if you can't do it manually for some reason.

@parimalyeole1
Copy link

Any update on this
I am using this "@ago-dev/nx-aws-cdk-v2": "^1.6.1" version

And when I run nx generate @ago-dev/nx-aws-cdk-v2:application common-infra

Getting this error:
(0 , devkit_1.readWorkspaceConfiguration) is not a function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants