Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional facebook/pop #24

Open
zenangst opened this issue Oct 26, 2016 · 1 comment
Open

Optional facebook/pop #24

zenangst opened this issue Oct 26, 2016 · 1 comment

Comments

@zenangst
Copy link

First of, kudos on a really neat wrapper library around animations. Personally I hope Apple would Sherlock from these kind of libraries in the future. One thing that struck me as a potential improvement to the library is to make the pop animations optional. If you are looking for just a neat wrapper around animation but don't really have or see the need for the entire Facebook/pop framework, it would be neat to be able to opt-out.

PromiseKit has solved this by using extensions, maybe you guys could do the same for pop, or any other framework for that mano. So if you one day have the need, then you just add the extension and BAM! pop is just there. Anyways, looks great. Keep up the good work!

References:

https://github.com/mxcl/PromiseKit#extensions

@hfossli
Copy link
Contributor

hfossli commented Oct 27, 2016

Thank you Christoffer! That's a very good idea. I totally agree. That should be a requirement for our 1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants