Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ergonomics of calling get_test_data from fv3core and fv3gfs-physics directories #206

Open
jdahm opened this issue Jun 6, 2022 · 1 comment
Labels
question Further information is requested refactor Code clean up or deeper refactoring tasks

Comments

@jdahm
Copy link
Contributor

jdahm commented Jun 6, 2022

As a consumer I find it odd that we call get_test_data for the driver from the fv3core directory with TARGET=driver. Should this be moved to the driver directory at some point?

@mcgibbon
Copy link
Collaborator

mcgibbon commented Jun 7, 2022

From the physics directory is normally where you'd download with TARGET=driver, but it's duplicated in between there and dycore.

We should avoid making a third copy of this infrastructure.

Once we remove the duplication of work in these two places (already have for the test logic in #209, we may also want to do this for the docker images), it should be easier to consolidate all of these into one test entrypoint that lets you select e.g. "I want to run the dycore translate tests only" but is also able to run all tests.

@FlorianDeconinck FlorianDeconinck added question Further information is requested refactor Code clean up or deeper refactoring tasks labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested refactor Code clean up or deeper refactoring tasks
Projects
None yet
Development

No branches or pull requests

3 participants