Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better integration of halo exchange #417

Open
FlorianDeconinck opened this issue Dec 22, 2022 · 0 comments
Open

Better integration of halo exchange #417

FlorianDeconinck opened this issue Dec 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@FlorianDeconinck
Copy link
Contributor

The current version of the integration of halo exchange uses WrappedHaloExchange class to allow orchestration and stencil backends to co-exists (due to DaCe parsing limitations).

This has two issues:

  • Goes against the "state-less" design of the code by requiring the same state to be passed to __init__ and __call__ of the model
  • Performance of the orchestration is limited by the callback which acts as a black-box funnel for the data-flow

Solutions:

  • Using literal list, which is pending a DaCe feature to be finished, we could keep the callback but remove the state from __init__
  • Furthermore, we could recode the custom pack/unpack in a language that DaCe can parse then do away with the wrapper altogether
@FlorianDeconinck FlorianDeconinck added the enhancement New feature or request label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant