Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for Project Milestone 1 (by Team Ampersand) #32

Open
kamblenikhil opened this issue Feb 10, 2022 · 1 comment
Open

Feedback for Project Milestone 1 (by Team Ampersand) #32

kamblenikhil opened this issue Feb 10, 2022 · 1 comment

Comments

@kamblenikhil
Copy link

kamblenikhil commented Feb 10, 2022

Hello Orion,

I have few suggestions -

  1. I see your Readme file in all the branches are giving good instructions to run your project, please update your wiki page with your Readme file
  2. Instead of cloning repo for every microservice you can create a seperate release branch with all your microservices included.
  3. Your Plot Graph Microservice doesn't work locally but works fine on docker.

Apart from this, the project works smothly.

Thanks,
Nikhil (Team Ampersand)

@anbadrin
Copy link
Contributor

Thank you so much for your feedback. We have modified the readme file in the main branch and main wiki. We will try to keep the suggestion of creating a new release branch to make things easier in our next milestone. As mentioned by you, the plot graph service seems to be creating some issue in the local. We have removed those steps from the readme and will look into the issue. But the service seems to be working fine in docker and should be able to work in the end to end flow using docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants