You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Message type values are always in the range 0-47 inclusive, because there are only 6 bits available to hold the message type, and by definition they are non-negative.
While all of the various message parsers reflect this by defining a property of the form public uint MessageType => ..., the NmeaPayloadParser.PeekMessageType method inexplicably returns an int.
I can't think of any good reason why I would have done that, so I believe this was a simple mistake.
Since we're still in v0.x versioning, it's not technically a semver violation to fix this.
The text was updated successfully, but these errors were encountered:
Message type values are always in the range 0-47 inclusive, because there are only 6 bits available to hold the message type, and by definition they are non-negative.
While all of the various message parsers reflect this by defining a property of the form
public uint MessageType => ...
, theNmeaPayloadParser.PeekMessageType
method inexplicably returns anint
.I can't think of any good reason why I would have done that, so I believe this was a simple mistake.
Since we're still in v0.x versioning, it's not technically a semver violation to fix this.
The text was updated successfully, but these errors were encountered: