Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NmeaPayloadParser.PeekMessageType returns a signed int #91

Open
idg10 opened this issue Mar 3, 2021 · 0 comments
Open

NmeaPayloadParser.PeekMessageType returns a signed int #91

idg10 opened this issue Mar 3, 2021 · 0 comments

Comments

@idg10
Copy link
Contributor

idg10 commented Mar 3, 2021

Message type values are always in the range 0-47 inclusive, because there are only 6 bits available to hold the message type, and by definition they are non-negative.

While all of the various message parsers reflect this by defining a property of the form public uint MessageType => ..., the NmeaPayloadParser.PeekMessageType method inexplicably returns an int.

I can't think of any good reason why I would have done that, so I believe this was a simple mistake.

Since we're still in v0.x versioning, it's not technically a semver violation to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant