Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Component #29

Open
jdic opened this issue Nov 13, 2024 · 1 comment · May be fixed by #30
Open

Icon Component #29

jdic opened this issue Nov 13, 2024 · 1 comment · May be fixed by #30
Assignees
Labels
🌟 Feature New functionality.

Comments

@jdic
Copy link
Member

jdic commented Nov 13, 2024

Because the icons have a very similar structure and are repeated in various parts of the code, an <Icon /> component should be created to reuse where required and at the same time facilitate future changes to the icons.

Once created in the component, replace everywhere where there are icons with the new component.

The component must have the following props:

  • className (Generic Interface)
  • icon (JSX.Element)

Something like this:

<Icon icon={<pony/>} className=“classes... />
@jdic jdic added the 🌟 Feature New functionality. label Nov 13, 2024
@jdic jdic added this to meca-store Nov 13, 2024
@jdic jdic moved this to 📋 Backlog in meca-store Nov 13, 2024
@CarlosP1e CarlosP1e moved this from 📋 Backlog to 🚧 In progress in meca-store Nov 13, 2024
@jdic
Copy link
Member Author

jdic commented Nov 13, 2024

You must create the component in:

src/modules/common

@CarlosP1e CarlosP1e linked a pull request Nov 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 Feature New functionality.
Projects
Status: 🔥 Blocked
Development

Successfully merging a pull request may close this issue.

2 participants