Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving task868_cfq_mcd1_explanation_to_sql.json #492

Open
danyaljj opened this issue Oct 28, 2021 · 4 comments
Open

Improving task868_cfq_mcd1_explanation_to_sql.json #492

danyaljj opened this issue Oct 28, 2021 · 4 comments
Labels

Comments

@danyaljj
Copy link
Contributor

This task seems to be quite difficult. Wondering if there is a way for us to improve it.

@danyaljj danyaljj added the urgent label Nov 3, 2021
@swarooprm
Copy link
Contributor

@ujjwalaananth, can you have a look at this?

@ujjwalaananth
Copy link
Contributor

Difficult in terms of the explanation not being clear, or difficult as in the expected answers are too complicated? In the latter case, maybe removing { } and escape sequences like \n would make it much clearer, as they are only there for human readability I believe and the resulting query would still be correct, but more straightforward to learn.

@ujjwalaananth
Copy link
Contributor

ujjwalaananth commented Nov 4, 2021

For example, for the input "Did M0 's art director , director , producer , and writer executive produce , write , produce , and direct M1"

current output is
"SELECT count(*) WHERE {\n?x0 ns:film.director.film M0 .\n?x0 ns:film.director.film M1 .\n?x0 ns:film.film_art_director.films_art_directed M0 .\n?x0 ns:film.producer.films_executive_produced M1 .\n?x0 ns:film.producer.film|ns:film.production_company.films M0 .\n?x0 ns:film.producer.film|ns:film.production_company.films M1 .\n?x0 ns:film.writer.film M0 .\n?x0 ns:film.writer.film M1\n}"

but maybe this could be simplified to
"SELECT count(*) WHERE x0 ns:film.director.film M0 . x0 ns:film.director.film M1 . x0 ns:film.film_art_director.films_art_directed M0 . x0 ns:film.producer.films_executive_produced M1 . x0 ns:film.producer.film|ns:film.production_company.films M0 . x0 ns:film.producer.film|ns:film.production_company.films M1 . x0 ns:film.writer.film M0 . x0 ns:film.writer.film M1"

(\n and braces removed)
(however I cannot guarantee this query is correct.)

@danyaljj
Copy link
Contributor Author

Right, I am actually not sure. For now, let's keep the issue open, in case we have good ideas for solving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants