Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2os_urdf does not conform ros naming and FSH conventions #23

Open
progtologist opened this issue Jun 11, 2014 · 3 comments
Open

p2os_urdf does not conform ros naming and FSH conventions #23

progtologist opened this issue Jun 11, 2014 · 3 comments

Comments

@progtologist
Copy link
Contributor

According to the urdf and xacro guides, the package p2os_urdf needs restructuring and should comply to ROS standards to help maintainability and future upgrades.

@allenh1
Copy link
Owner

allenh1 commented Jun 13, 2014

Could you attempt to resolve this issue while I am fixing the coding style issue?

@progtologist
Copy link
Contributor Author

Yes, I will work on that and issue PR as soon as this is ready!

@progtologist
Copy link
Contributor Author

We should move the p2os_publisher functionality to the driver. Since the publication of the joint states is actually something that the driver should be doing, and not the urdf file. This way the gazebo plugin (which publishes the joint states) will cause no conflicts (either you run the driver node and get the states from the actual robot, or you run gazebo and get the states from the simulated robot).

I will integrate this change in my PR, is this ok with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants