You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to the urdf and xacro guides, the package p2os_urdf needs restructuring and should comply to ROS standards to help maintainability and future upgrades.
The text was updated successfully, but these errors were encountered:
We should move the p2os_publisher functionality to the driver. Since the publication of the joint states is actually something that the driver should be doing, and not the urdf file. This way the gazebo plugin (which publishes the joint states) will cause no conflicts (either you run the driver node and get the states from the actual robot, or you run gazebo and get the states from the simulated robot).
I will integrate this change in my PR, is this ok with you?
According to the urdf and xacro guides, the package p2os_urdf needs restructuring and should comply to ROS standards to help maintainability and future upgrades.
The text was updated successfully, but these errors were encountered: