Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add serde feature #79

Open
SyedAhkam opened this issue Dec 27, 2024 · 1 comment
Open

add serde feature #79

SyedAhkam opened this issue Dec 27, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@SyedAhkam
Copy link

Hi,

I wished to send the ProofNodes to an external source or a ZKVM (SP1) but I am unable to use serde to serialize the structure because the type doesn't implement the Serialize trait.

I even tried to take ownership of the inner hashmap, which goes from Nibble --> Bytes, but turns out that the type Nibble is also missing a Serialize implementation.

Any workarounds / is it considerable adding support for it?

@DaniPopes
Copy link
Member

Nibbles implements serde under the feature https://github.com/alloy-rs/nybbles/blob/cb21a5a43282577d57a97de277332606e48cdfcc/src/nibbles.rs#L59

It should also be exposed in this crate too, feel free to to open a PR for it

@mattsse mattsse changed the title Missing Serde support for ProofNodes type add serde feature Dec 28, 2024
@mattsse mattsse added the good first issue Good for newcomers label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants