Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: optional pre-allocation #1

Open
onlyjob opened this issue Sep 16, 2017 · 1 comment
Open

feature: optional pre-allocation #1

onlyjob opened this issue Sep 16, 2017 · 1 comment

Comments

@onlyjob
Copy link

onlyjob commented Sep 16, 2017

Pre-allocation may be useless

  • When file system is exclusively used by one application
  • On certain file systems

Please consider making pre-allocation optional.

Thanks.

@dylanetaft
Copy link

A quick commit review - I don't think they're preallocating primarily to reduce filesystem fragmentation. They're doing it to avoid inner-file fragmentation, internally the file is ordered - see line 364
266d849

So when you go to read it, you're not seeking all over, the file becomes indexed.
Not sure how the miner code handles reading the file. Would have to review to ensure it uses that indexed order to benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants