-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I added .Net 5 support #46
Comments
Well done! As a feedback I would recommend to multitarget to both |
Would it make sense for you to collaborate with @Andy9FromSpace in #42? |
UWP is still using standard 2.0 ? Oh ok. Then if a user will raise the hand he needs it, I'll revert related commits. Animator posted in https://github.com/microsoft/ProjectReunion/issues/105 a description, how he use .Net5 with UWP. Maybe that already delivers what is neccessary. |
The solution in that topic does not result in apps you can publish, it is only a proof of concept, based on hacks, that works in debug mode (because then the normal compiler is used). When you publish an app to the store it gets compiled using .Net Native which does not support .net 5. If you allow for multitargeting to both netstandard2.0 and net5.0 then you can support all people. By the way, what do you miss in netstandard2.0 which is in the pr I mentioned already? |
"By the way, what do you miss in netstandard2.0 which is in the pr I mentioned already?" |
I understand, but when you have a Net5.0 project, you could still reference aforge.net if that targets netstandard2.0. Functionally there is no difference, unless you want
In these two cases it helps to offer a .net 5 version of aforge.net. Especially for the second point, multitargeting is enough (adding both Net5.0 and netstandard2.0 as target frameworks). For the first part, I'm not sure whether multitargeting is possible. |
Wait - the targetframework setting isnt anymore part of the projectfiles. |
... because this project isnt maintained anymore, I made my changes at
https://github.com/Micke3rd/AForge.NET
I had to exclude a few things to compile it, and not all unit tests run successfully.
So feel free to update what you need.
The text was updated successfully, but these errors were encountered: