Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired certificates are not handled #712

Open
andyholmes opened this issue Aug 17, 2024 · 3 comments
Open

Expired certificates are not handled #712

andyholmes opened this issue Aug 17, 2024 · 3 comments
Labels
security An issue that compromises security or privacy UI/UX An issue that affects the user interface or experience

Comments

@andyholmes
Copy link
Owner

Current Behavior

Until now (at least), KDE Connect clients generate certificates with a 10-year expiry. With KDE Connect passing its 10th birthday awhile back, certificates have started to expire and cause silent errors.

Expected Behavior

Valent should handle certificate regeneration or notification of expiration automatically. Ideally, it should also be able to notify if a connection is refused because a remote device's certificate is expired.

Desktop

Other (please specify)

Other Desktop

All platforms

Operating System

All operating systems

Installed from

Nightly Flatpak

Version

nightly

Devices

No response

Plugins

No response

Logs

No response

Screenshots

No response

@andyholmes andyholmes added triage An issue that needs confirmation and labeling security An issue that compromises security or privacy UI/UX An issue that affects the user interface or experience and removed triage An issue that needs confirmation and labeling labels Aug 17, 2024
@quack-o
Copy link

quack-o commented Jan 3, 2025

this is happening with my new device, it shows up for a second in valent and then dissapear.

authenticating (192.168.1.45:1716): Invalid certificate for "91c110b9_b5fa_4cb3_9294_4f1971d6d132"

but weirdly, it doesnt connection between 2 androids running kdeconnect ?

also any fix for this temporarily ?

@andyholmes
Copy link
Owner Author

If your ID is 91c110b9_b5fa_4cb3_9294_4f1971d6d132 then your certificate hasn't expired, you've encountered a different error. Could you open a separate report?

@quack-o
Copy link

quack-o commented Jan 4, 2025

added #769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security An issue that compromises security or privacy UI/UX An issue that affects the user interface or experience
Projects
None yet
Development

No branches or pull requests

2 participants