diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml new file mode 100644 index 00000000..506282de --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -0,0 +1,57 @@ +name: Bug Report +description: Report a bug or regression in functionality + +body: + - type: dropdown + id: affected-packages + attributes: + label: With what library do you have an issue? + options: + - native-federation + - module-federation + validations: + required: true + + - type: textarea + id: reproduction + attributes: + label: Reproduction of the bug/regression with instructions + description: If on Native Federation, use our [Stackblitz template](https://stackblitz.com/github/rainerhahnekamp/native-federation-stackblitz?file=projects%2Fhost%2Fsrc%2Fapp%2Fapp.routes.ts) to reproduce the issue + placeholder: If the bug/regression does not include a reproduction via StackBlitz or GitHub repo, your issue may be closed without resolution. + validations: + required: true + + - type: textarea + id: expected_behavior + attributes: + label: Expected behavior + description: Describe what the expected behavior would be. + validations: + required: true + + - type: textarea + id: version + attributes: + label: Versions of Native/Module Federation, Angular, Node, Browser, and operating system + placeholder: | + Native/Module Federation: + Angular: + Node: + Browser: + Operating system(s): + validations: + required: true + + - type: textarea + id: other + attributes: + label: Other information + + - type: checkboxes + id: assistance + attributes: + label: I would be willing to submit a PR to fix this issue + description: Assistance is provided if you need help submitting a pull request + options: + - label: 'Yes' + - label: 'No' diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml new file mode 100644 index 00000000..fd08ab2e --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature-request.yml @@ -0,0 +1,37 @@ +name: Feature Request +description: Submit a Request For Consideration + +body: + - type: dropdown + id: affected-packages + attributes: + label: For which library do you have a feature request? + options: + - native-federation + - module-federation + - other + multiple: true + validations: + required: true + + - type: textarea + id: information + attributes: + label: Information + description: What feature would you like to see added? + validations: + required: true + + - type: textarea + id: alternatives + attributes: + label: Describe any alternatives/workarounds you're currently using + + - type: checkboxes + id: assistance + attributes: + label: I would be willing to submit a PR to fix this issue + description: Assistance is provided if you need help submitting a pull request + options: + - label: 'Yes' + - label: 'No' diff --git a/.github/ISSUE_TEMPLATE/question.yml b/.github/ISSUE_TEMPLATE/question.yml new file mode 100644 index 00000000..fc9afc18 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/question.yml @@ -0,0 +1,23 @@ +name: Question / Help +description: Ask a question or request help + +body: + - type: dropdown + id: affected-packages + attributes: + label: For which library do you need help? + options: + - native-federation + - module-federation + - other + multiple: true + validations: + required: true + + - type: textarea + id: information + attributes: + label: Question + description: What do you need help with? + validations: + required: true diff --git a/libs/native-federation/src/builders/build/builder.ts b/libs/native-federation/src/builders/build/builder.ts index 98e1e0a4..5f059740 100644 --- a/libs/native-federation/src/builders/build/builder.ts +++ b/libs/native-federation/src/builders/build/builder.ts @@ -122,6 +122,10 @@ export async function* runBuilder( options.baseHref = nfOptions.baseHref; } + if(nfOptions.outputPath){ + options.outputPath = nfOptions.outputPath; + } + const rebuildEvents = new RebuildHubs(); const adapter = createAngularBuildAdapter(options, context, rebuildEvents); diff --git a/libs/native-federation/src/builders/build/schema.d.ts b/libs/native-federation/src/builders/build/schema.d.ts index 1ca3bd6e..301e1612 100644 --- a/libs/native-federation/src/builders/build/schema.d.ts +++ b/libs/native-federation/src/builders/build/schema.d.ts @@ -12,5 +12,6 @@ export interface NfBuilderSchema extends JsonObject { skipHtmlTransform: boolean; esmsInitOptions: ESMSInitOptions; baseHref?: string; + outputPath?: string; ssr: boolean; } // eslint-disable-line diff --git a/libs/native-federation/src/builders/build/schema.json b/libs/native-federation/src/builders/build/schema.json index d08f27cf..6fe15f4b 100644 --- a/libs/native-federation/src/builders/build/schema.json +++ b/libs/native-federation/src/builders/build/schema.json @@ -46,6 +46,9 @@ "baseHref": { "type": "string" }, + "outputPath": { + "type": "string" + }, "esmsInitOptions": { "type": "object", "description": "Options for esms-module-shims https://github.com/guybedford/es-module-shims?tab=readme-ov-file#init-options", diff --git a/libs/native-federation/src/utils/angular-esbuild-adapter.ts b/libs/native-federation/src/utils/angular-esbuild-adapter.ts index 66939c14..3a7279f3 100644 --- a/libs/native-federation/src/utils/angular-esbuild-adapter.ts +++ b/libs/native-federation/src/utils/angular-esbuild-adapter.ts @@ -269,7 +269,7 @@ async function runEsbuild( splitting: kind === 'mapping-or-exposed', platform: 'browser', format: 'esm', - target: ['esnext'], + target: target, logLimit: kind === 'shared-package' ? 1 : 0, plugins: plugins || [ createCompilerPlugin(