Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.8 support #37

Open
grant-olson opened this issue Apr 26, 2020 · 1 comment
Open

python 3.8 support #37

grant-olson opened this issue Apr 26, 2020 · 1 comment
Assignees

Comments

@grant-olson
Copy link

We should support python 3.8 or if that proves too difficult we should have a friendly error message instead of a big ugly traceback in the futures code.

@grant-olson grant-olson self-assigned this Apr 26, 2020
@ikkez
Copy link

ikkez commented May 12, 2020

Hi there. The SDK actually run fine on python3.8.. it's just that the futures in 3.8 slightly changed the error handling. The problem with the "big ugly traceback" is that the connection is closed / destoried before all the listeners were shutdown. That was no problem in 3.7 and before and just failed silently. I'm not that deep into python yet, but in the SDK fork I did some time ago, I just workaround that's bug with a simple little timeout, see this lines:

ikkez@103fda2

That seems to work just fine, but there's probably a better, more correct way to solve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants