Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why hidden modal by setTimeout? #1

Open
MrHeer opened this issue Jun 10, 2022 · 3 comments · May be fixed by #2
Open

Why hidden modal by setTimeout? #1

MrHeer opened this issue Jun 10, 2022 · 3 comments · May be fixed by #2

Comments

@MrHeer
Copy link

MrHeer commented Jun 10, 2022

First of all, Thank you develop this awesome app. There is a problem to me. In some long word, the modal be hidden while the audio still playing.

cpwp/src/App.vue

Lines 90 to 92 in 621044e

setTimeout(() => {
modal.value = false
}, 1000)

Maybe can use ended event

@antfu
Copy link
Owner

antfu commented Jun 10, 2022

Sure. PR welcome!

@MrHeer
Copy link
Author

MrHeer commented Jun 13, 2022

I will try.

@MrHeer
Copy link
Author

MrHeer commented Jun 13, 2022

There are some problem when I run pmpm install.

$ pnpm install

Progress: resolved 552, reused 552, downloaded 0, added 552, done
node_modules/.pnpm/[email protected][email protected]/node_modules/vue-demi: Running postinstall script...
node_modules/.pnpm/[email protected]/node_modules/esbuild: Running postinstall script, failed in 36ms
.../[email protected]/node_modules/esbuild postinstall$ node install.js
│ Unsupported platform: darwin arm64 LE
└─ Failed in 36ms
node_modules/.pnpm/[email protected]/node_modules/esbuild: Running postinstall script...

I try to upgrade esno to 0.8.0, I installed success. But some new problems When I run pnpm dev

> [email protected] dev ./cpwp
> vite --port 3333 --open

[vite] Optimizable dependencies detected:
@vueuse/core, vue

  Dev server running at:
  > Local:    http://localhost:3333/
  > Network:  http://192.168.1.5:3333/


[vite] SFC <script setup> compilation error:
./cpwp/src/App.vue
[@vue/compiler-sfc] <script setup> cannot contain ES module exports. If you are using a previous version of <script setup>, please consult the updated RFC at https://github.com/vuejs/rfcs/pull/227.

./cpwp/src/App.vue
71 |  import { ref } from 'vue'
72 |  import raw from './data.json'
73 |
   |   ^
74 |  export const data = ref(raw)
   |  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
75 |  export const word = ref('')

warn - You have enabled experimental features: applyComplexClasses, uniformColorPalette, extendedSpacingScale, extendedFontSizeScale
warn - Experimental features are not covered by semver, may introduce breaking changes, and can change at any time.

[vite] SFC <script setup> compilation error:
./cpwp/src/components/Footer.vue
[@vue/compiler-sfc] <script setup> cannot contain ES module exports. If you are using a previous version of <script setup>, please consult the updated RFC at https://github.com/vuejs/rfcs/pull/227.

./cpwp/src/components/Footer.vue
15 |  </template>
16 |
17 |  <script setup lang='ts'>
   |                           ^
18 |  export { isDark } from '/~/utils'
   |  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
19 |  </script>

[vite] SFC <script setup> compilation error:
./Src/cpwp/src/components/Icon.vue
[@vue/compiler-sfc] <script setup> cannot contain ES module exports. If you are using a previous version of <script setup>, please consult the updated RFC at https://github.com/vuejs/rfcs/pull/227.

./Src/cpwp/src/components/Icon.vue
10 |    icon: string
11 |  }
12 |
   |   ^
13 |  export const el = ref<HTMLElement | null>(null)
   |  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
14 |

@MrHeer MrHeer linked a pull request Sep 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants