randomize listen port. makes the tests pass on macos. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@perbu ok nice catch. How do we proceed with this PR? |
|
I suggest we just merge it. The only issue would be the very small chance that we get a port conflict if the random generator would happen to return the same port twice. If you want I could add that, let me know. Changes are small as we pick a random port out of 50K or so. |
|
@perbu Yeah. We can merge this. Thanks again for your work! Really appreciate this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this one test was failing on macos. this fires up remotes on random ports on localhost. It'll likely use tcp6 where available, which is a bonus, I guess.