Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: project-local types file #14

Open
refactorized opened this issue Dec 19, 2020 · 1 comment
Open

Feature request: project-local types file #14

refactorized opened this issue Dec 19, 2020 · 1 comment

Comments

@refactorized
Copy link

Currently creating a new project results in this generated jsconfig.json file

{
  "include": [
    "*.js",
    "libraries/*.js",
    "/Users/adam/.vscode/extensions/samplavigne.p5-vscode-1.2.4/p5types/global.d.ts"
  ]
}

Which references the types file by an absolute path that includes a user name. I will have to copy this to a local directory if I want to put it on git or share it with others. As there is already a libraries directory in a new project, could the types file be created there as well, and referenced with a relative path in the config file?

This could be a toggleable option, but I don't see too much problem in just having the file copied in by default.

Thanks

@antiboredom
Copy link
Owner

Good idea! When I made this I was trying to minimize how many files the project required, and at the time it seemed to make more sense to simply add the json file rather than the type definitions... Will definitely consider adding this in, and of course feel free to make a pull request if you are so inclined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants