Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nightly-only simd feature and related code in ArrowNumericType #5185

Closed
jhorstmann opened this issue Dec 7, 2023 · 1 comment · Fixed by #5184
Closed

Remove nightly-only simd feature and related code in ArrowNumericType #5185

jhorstmann opened this issue Dec 7, 2023 · 1 comment · Fixed by #5184
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@jhorstmann
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

With the merge of #5100 all users of the feature-gated methods in ArrowNumericType should be gone and those functions can be removed.

Describe the solution you'd like

  • Remove simd related functions from ArrowNumericType trait
  • Remove bit_util::bitwise_bin_op_simd which seems to be unused
  • Remove simd feature and packed_simd dependency

Describe alternatives you've considered

The ArrowNumericType seems a little bit redundant with ArrowNativeTypeOp, but removing it completely would involve a lot of little api changes, so it's probably better to keep it as an empty marker trait.

Additional context

@jhorstmann jhorstmann added the enhancement Any new improvement worthy of a entry in the changelog label Dec 7, 2023
@tustvold tustvold added the arrow Changes to the arrow crate label Jan 5, 2024
@tustvold
Copy link
Contributor

tustvold commented Jan 5, 2024

label_issue.py automatically added labels {'arrow'} from #5184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants