Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temp dir property for native library #4533

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

equanz
Copy link
Contributor

@equanz equanz commented Dec 4, 2024

Motivation

If the default temporary directory is not available, native libraries cannot be loaded.

For this situation, other projects have the ability to set custom working directory.
I would like to add such feature to BookKeeper.

examples:

Changes

  • Add temp dir property for native library

Copy link
Contributor

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea lgtm but please refactor this into a reusable utility method so the code is not repeated 3 times.

@equanz equanz force-pushed the add_temp_dir_property_for_native_library branch 3 times, most recently from f1ed167 to a7d31a8 Compare December 10, 2024 10:39
@equanz
Copy link
Contributor Author

equanz commented Dec 10, 2024

@dlg99
I created the new submodule native-library-common and try to add it to shade target.

I'm not sure why native-io is not shaded, but I only added native-library-common.
In my understanding, native-library-common (and guava) is imported even if shaded beacuse native-io requires it.
To avoid this issue, for example, shade native-io as well, or create a class for native-io like 7131e51 .

What do you think?

@equanz
Copy link
Contributor Author

equanz commented Dec 11, 2024

I decided to remove guava from native-library-common.

@dlg99 PTAL

@equanz equanz requested a review from dlg99 December 11, 2024 12:36
@dlg99
Copy link
Contributor

dlg99 commented Dec 11, 2024

LGTM but please check what's up with the CI / why PR validation is failing

@equanz equanz closed this Dec 12, 2024
@equanz equanz reopened this Dec 12, 2024
@equanz equanz force-pushed the add_temp_dir_property_for_native_library branch from 2a402a6 to d43b749 Compare December 12, 2024 09:32
@equanz
Copy link
Contributor Author

equanz commented Dec 12, 2024

A failed job runs on Ubuntu 24.04.1 LTS.

Conversely, succeeded jobs run on Ubuntu 22.04.5 LTS.

It's probably due to the actions/runner-images#10636.

I tested it in below.

I am now considering downgrading the image version to ubuntu-22.04. However, we need to address this issue.

@equanz
Copy link
Contributor Author

equanz commented Dec 12, 2024

Addressed #4533 (comment) issue in #4536.

@equanz equanz force-pushed the add_temp_dir_property_for_native_library branch from d43b749 to aa45676 Compare December 20, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants