-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add temp dir property for native library #4533
base: master
Are you sure you want to change the base?
Add temp dir property for native library #4533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea lgtm but please refactor this into a reusable utility method so the code is not repeated 3 times.
f1ed167
to
a7d31a8
Compare
@dlg99 I'm not sure why What do you think? |
I decided to remove guava from native-library-common. @dlg99 PTAL |
LGTM but please check what's up with the CI / why PR validation is failing |
2a402a6
to
d43b749
Compare
A failed job runs on Conversely, succeeded jobs run on
It's probably due to the actions/runner-images#10636. I tested it in below.
I am now considering downgrading the image version to |
Addressed #4533 (comment) issue in #4536. |
d43b749
to
aa45676
Compare
Motivation
If the default temporary directory is not available, native libraries cannot be loaded.
For this situation, other projects have the ability to set custom working directory.
I would like to add such feature to BookKeeper.
examples:
Changes