Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataFusion to 43 #1125

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Conversation

Dandandan
Copy link
Contributor

Which issue does this PR close?

Closes #1124

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Dandandan Dandandan changed the title Update DataFusions to 43 Update DataFusion to 43 Nov 20, 2024
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dandandan

@Dandandan
Copy link
Contributor Author

I can succesfully run the tpc-h queries, let's wait until build is green.

@milenkovicm
Copy link
Contributor

I have mixed feelings about keeping that test which involves ballista python, should we remove it and risk breaking python from time to time? wdyt @Dandandan @andygrove

@Epicism
Copy link

Epicism commented Nov 20, 2024 via email

@milenkovicm
Copy link
Contributor

once we merge this patch, ballista will read deltalake (custom codecs needed)

  let config = SessionConfig::new_with_ballista()
      .with_target_partitions(1)
      .with_ballista_standalone_parallelism(2)
      .with_ballista_logical_extension_codec(Arc::new(BallistaDeltaLogicalCodec::default()))
      .with_ballista_physical_extension_codec(Arc::new(BallistaDeltaPhysicalCodec::default()));

  let state = SessionStateBuilder::new()
      .with_config(config)
      .with_default_features()
      .build();

  let table = deltalake::open_table("/Users/ballissta/TMP/delta_table/")
      .await
      .unwrap();

  let ctx = SessionContext::standalone_with_state(state).await?;

  ctx.register_table("demo", Arc::new(table)).unwrap();

  let df = ctx.sql("select * from demo").await?;

  df.show().await?;

relates to #457

@tbar4
Copy link
Contributor

tbar4 commented Nov 27, 2024

PoV: Shouldn't the Python code be in its own repo? Ballista is being redesigned as a library, and Python is an application of the library...

On Wed, Nov 20, 2024 at 4:05 PM Marko Milenković @.> wrote: I have mixed feelings about keeping that test which involves ballista python, should we remove it and risk breaking python from time to time? wdyt @Dandandan https://github.com/Dandandan @andygrove https://github.com/andygrove — Reply to this email directly, view it on GitHub <#1125 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNEIPJOQLOCMX5DNZEFQGL2BT2P7AVCNFSM6AAAAABSFBQZ3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBZGUZTSMRTGI . You are receiving this because you are subscribed to this thread.Message ID: @.>

We could split it into its own repo, but right now it seems like it is just Marko, Andy, Daniel, and I that have been making updates. If Ballista Python gets more support than me there could be an argument for it, but at this time it is better to manage it all in one place.

@tbar4
Copy link
Contributor

tbar4 commented Nov 27, 2024

@milenkovicm
Copy link
Contributor

With (py)ballista issues outlined in #1142 would it make sense to release this version without it? That would give us some time to figure out python support?

Wdyt @andygrove ?

@milenkovicm
Copy link
Contributor

@Dandandan could you please rebase this PR now when we have datafusion python released ?
(don't worry if you have time to fix py part, i can follow up with PR later )

@Dandandan
Copy link
Contributor Author

@milenkovicm This is now up to date with main

@milenkovicm
Copy link
Contributor

Thanks @Dandandan!

Would you be able to merge this and other two open PR, looks like @andygrove is busy and I have no merge rights

@Dandandan Dandandan merged commit 167bbf9 into apache:main Dec 19, 2024
17 of 24 checks passed
@Dandandan
Copy link
Contributor Author

Would you be able to merge this and other two open PR, looks like @andygrove is busy and I have no merge rights

Yes, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to DataFusion 43
5 participants