Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid link to apache archive server directly #978

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Avoid link to apache archive server directly #978

wants to merge 5 commits into from

Conversation

Shawyeok
Copy link

@Shawyeok Shawyeok commented Dec 17, 2024 •
edited
Loading

Fixed apache/pulsar#23710, following the guide use closer.lua link in download instructions.

@Shawyeok Shawyeok mentioned this pull request Dec 17, 2024
Open
2 tasks
lhotari
lhotari requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the change also to the maintained versions in versioned_docs/version-4.0.x and versioned_docs/version-3.0.x directories.
More details in https://github.com/apache/pulsar-site?tab=readme-ov-file#updating-versioned-docs and https://pulsar.apache.org/contribute/document-contribution/#update-versioned-docs .

The recommended approach is to first update the docs directory document and then use the tool to apply the patch to maintained versions.

@Shawyeok
Copy link
Author

Shawyeok commented Dec 17, 2024 •
edited by lhotari
Loading

Make changes also to 4.0.x is reasonable, for 3.0.x, I wonder when 3.0.x reaches EOF, is there an automatic mechanism to modify the distribution URL to the archive server, or is it guaranteed that the latest 3.0.x package will always remain available on https://downloads.apache.org/pulsar/?

Files are manually deleted from downloads.apache.org by deleting them from https://dist.apache.org/repos/dist/release/pulsar/ with svn. We'll keep latest 3.0.x downloadable until the end of support, so it's worth updating 3.0.x instructions too.

Btw. I'm not sure if downloads.apache.org is an acceptable link. In apache/pulsar#23710, there's nothing that says that the link should be downloads.apache.org link. Instead in the guide, it says that closer.lua must be used. (checksums and signatures should use the downloads.apache.org URL).

@Shawyeok Shawyeok requested a review from lhotari December 17, 2024 10:34
@Shawyeok
Copy link
Author

Btw. I'm not sure if downloads.apache.org is an acceptable link. In apache/pulsar#23710, there's nothing that says that the link should be downloads.apache.org link. Instead in the guide, it says that closer.lua must be used. (checksums and signatures should use the downloads.apache.org URL).

@lhotari
Sorry for the late reply. It seems you edited my last comment, so I didn’t get any notifications about the edit.

I’ve updated the download instructions by adding a link with closer.lua and removing the wget command. This allows users to download the Pulsar release with just one or two clicks, making it more convenient.

@Shawyeok Shawyeok changed the title Change latest version distribution url to Apache Distribution Directory (downloads.apache.org) Avoid link to apache archive server directly Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari Awaiting requested review from lhotari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc] Download page must not use the archive server
2 participants
@Shawyeok @lhotari