Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Client Active Offline #4686

Closed
7 of 8 tasks
loongs-zhang opened this issue May 30, 2023 · 7 comments
Closed
7 of 8 tasks

[Task] Client Active Offline #4686

loongs-zhang opened this issue May 30, 2023 · 7 comments
Assignees
@xuziyang @847850277 @loongs-zhang
Labels
level: medium status: volunteer wanted Extra attention is needed

Comments

@loongs-zhang
Copy link
Member

loongs-zhang commented May 30, 2023 •
edited
Loading

Description

Currently, shenyu only supports passive offline, during which the front-end will have a clear perception (i.e. response 408), indicating that it is better to support active offline.

The idea is roughly:

  1. The client utilizes the mechanism provided by ShenyuClientShutdownHook to call the offline interface of shenyu admin;
  2. In the offline interface of shenyu admin, we update the database and send events;

Task List
@loongs-zhang loongs-zhang added the status: volunteer wanted Extra attention is needed label May 30, 2023
@loongs-zhang loongs-zhang self-assigned this May 30, 2023
@weiweily
Copy link

weiweily commented Jun 5, 2023

hello， when this will be ok？

@loongs-zhang
Copy link
Member Author

loongs-zhang commented Jun 5, 2023 •
edited
Loading

hello， when this will be ok？

At least 2.6.0

loongs-zhang pushed a commit to loongs-zhang/shenyu that referenced this issue Jun 5, 2023
[ISSUE apache#4686] divide support active offline
7e8a57b
yu199195 pushed a commit that referenced this issue Jun 6, 2023
@loongs-zhang
[ISSUE #4686] divide support active offline (#4702)
846ec64 
* [ISSUE #4686] divide support active offline

* fix javadoc

* fix test
@loongs-zhang
Copy link
Member Author

After discuss, we think the spring cloud active offline is not needed.

@loongs-zhang loongs-zhang reopened this Jun 20, 2023
@loongs-zhang loongs-zhang added this to the 2.6.0 milestone Jun 29, 2023
@xuziyang
Copy link
Contributor

xuziyang commented Jul 1, 2023

I would like to take on this job.

@xuziyang xuziyang mentioned this issue Jul 5, 2023
Merged
loongs-zhang added a commit that referenced this issue Jul 7, 2023
@xuziyang @loongs-zhang @yu199195
[ISSUE #4686] ZookeeperClientRegisterRepository active offline (#4806)
1b08ed0 
Co-authored-by: dragon-zhang <[email protected]>
Co-authored-by: xiaoyu <[email protected]>
@847850277
Copy link
Contributor

please asign ConsulClientRegisterRepository active offline and NacosClientRegisterRepository active offline to me.

@xuziyang
Copy link
Contributor

please asign ApolloClientRegisterRepository active offline to me.

@xuziyang xuziyang mentioned this issue Jul 16, 2023
Merged
loongs-zhang added a commit that referenced this issue Jul 16, 2023
@xuziyang @loongs-zhang
[ISSUE #4686] Admin actively synchronizes http service offline events…
22b4a8c 
… to the gateway (#4846)

* [ISSUE #4686] divide plugin active offline support shenyu-admin cluster

* Revert "[ISSUE #4686] divide plugin active offline support shenyu-admin cluster"

This reverts commit 9812311.

* [ISSUE #4686] Admin actively synchronizes http service offline events to the gateway

---------

Co-authored-by: dragon-zhang <[email protected]>
loongs-zhang pushed a commit that referenced this issue Jul 17, 2023
@xuziyang @yu199195
[ISSUE #4686] ApolloClientRegisterRepository active offline (#4855)
a62a04c 
Co-authored-by: xiaoyu <[email protected]>
847850277 added a commit to 847850277/shenyu that referenced this issue Jul 17, 2023
@847850277
feature: apache#4686 consul client active offline.
35f9c51
847850277 added a commit to 847850277/shenyu that referenced this issue Jul 24, 2023
@847850277
issues apache#4686: nacos client offline
ab43ac7
loongs-zhang added a commit that referenced this issue Jul 24, 2023
@847850277 @yu199195 @loongs-zhang
issues #4686: nacos client offline (#4890)
78dad37 
Co-authored-by: xiaoyu <[email protected]>
Co-authored-by: dragon-zhang <[email protected]>
@moremind moremind removed this from the 2.6.0 milestone Aug 3, 2023
@loongs-zhang
Copy link
Member Author

#5324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuziyang xuziyang

@847850277 847850277

@loongs-zhang loongs-zhang

Labels
level: medium status: volunteer wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@xuziyang @847850277 @moremind @weiweily @loongs-zhang