@IsaakKrut  thank you for this PR. The code looks good, but before we proceed, I think we should clarify some conceptual ideas in StreamPipes that are not quite clear yet.

General Considerations:

• Adapters vs. Data Streams: These are two distinct elements in our architecture, but they have interdependencies. We are currently not fully consistent with the concept due to these dependencies.

Topic 1:

• Data Source Changes: Your PR modifies the Data Source only. When we change Data Sources, we may also need to update the Pipelines. The functionality for handling this in Adapters can be found in AdapterResource.performPipelineMigrationPreflight. A similar approach might be required for Data Source updates.

Topic 2:

• Event Schema Handling:
  • This is not directly related to your PR, but it is an open issue in our system that your PR brought to light.
  • Problem: An Adapter creates a Data Stream. A user then changes the Event Schema of this Data Stream via the API. This can lead to a situation where the Adapter and the Data Source have different Event Schemas.
  • I'm not yet sure how to resolve this. We can discuss this separately if needed.

I think Topic 2 should be discussed in a separate thread, as there are additional points that need clarification.

How should we proceed with Topic 1? We could either:

• Option 1: Address it in this PR by implementing the necessary updates for Data Source changes.
• Option 2: Leave it for now and create a separate issue and PR after we have a solution for Topic 2.

Hi @tenthe, I can work on the option 1. I have a couple of questions though.

1. When updating the data stream should any changes be propagated to the corresponding AdapterDescription? They share fields inherited from NamedStreamPipesEntity. For example, I noticed name and description are set to the same value on adapter creation from the UI.
2. Current updates only update EventSchema on the pipeline DataStream. Should this new API do the same or it should replace the whole DataStream object?

Hi @IsaakKrut,

good questions. Here are some thoughs from my side.

Propagation changes to AdapterDescription:
Propagating changes to the event schema directly to AdapterDescription could be problematic, as it might require modifications to the adapter itself, which might be different for each adapter type. Currently we think about that adapters should manage their own event schemas, which would change how we display event streams and adapter instances in the pipeline editor. Then pipelines could either have a data stream or an adapter as a data source. Currently, each adapter creates a data stream as a seperate object that needs to be kept in sync. I suggest we discuss this further in a separate issue.

Updating DataStream:
Regarding this PR I suggest to propagate event schema changes in the DataStream through the pipeline, similar to how we handle adapter updates. Check AdapterResource.performPipelineMigrationPreflight() for reference, and the update logic is in AdapterUpdateManagement.updateAdapter at line 75.

Feel free to share your thoughts or ask any questions. I'm also not entirely sure what the best solution is, so we can discuss this further.

Hello there 👋

We noticed that it's been some time since activity occurred on your pull request 🤔. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed ⏰.

Please take a moment to review your pull request and make any necessary updates or changes 👨‍💻. If you need more time or have any questions, please don't hesitate to let us know 💬.

Thank you for your contributions to our project, and we look forward to hearing back from you soon 🙏.

Hello there 👋

Unfortunately, we didn't hear back from you regarding your pull request, so we're closing it now. Don't worry, you can always reopen the PR at any time if you wish to continue working on it 🙌.

Please note that the branch associated with this pull request will not be deleted, so you can still access your changes and continue to work on them as needed 💻.

Thank you for your contributions to our project, and we hope to see you again soon!