From 00625794f7f0ed8cc03d20e3e2732d877730c9d7 Mon Sep 17 00:00:00 2001 From: Srinandan Sridhar <13950006+srinandan@users.noreply.github.com> Date: Thu, 18 Jul 2024 09:27:19 -0700 Subject: [PATCH] bug: sets safeundeploy default to false #409 (#512) * bug: sets safeundeploy default to false #409 * bug: update the description #409 --- internal/cmd/apis/common.go | 2 +- internal/cmd/apis/undepapi.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/cmd/apis/common.go b/internal/cmd/apis/common.go index 68cf4ebcb..045945c96 100644 --- a/internal/cmd/apis/common.go +++ b/internal/cmd/apis/common.go @@ -21,7 +21,7 @@ import ( ) const deploymentMsg = "When set to true, generateDeployChangeReport will be executed and " + - "deployment will proceed if there are no conflicts; default is true" + "deployment will proceed if there are no conflicts; default is false" func GetRevision(respBody []byte) (revision int, err error) { var apiProxyRevResp map[string]interface{} diff --git a/internal/cmd/apis/undepapi.go b/internal/cmd/apis/undepapi.go index 0b422b8d7..e30f8bb3a 100644 --- a/internal/cmd/apis/undepapi.go +++ b/internal/cmd/apis/undepapi.go @@ -55,7 +55,7 @@ func init() { UndepCmd.Flags().IntVarP(&revision, "rev", "v", -1, "API Proxy revision. If not set, the highest revision is used") UndepCmd.Flags().BoolVarP(&safeUndeploy, "safeundeploy", "", - true, deploymentMsg) + false, deploymentMsg) _ = UndepCmd.MarkFlagRequired("env") _ = UndepCmd.MarkFlagRequired("name")