Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we make NIOFoundationCompat depend on FoundationEssentials? #3038

Open
t089 opened this issue Dec 26, 2024 · 1 comment
Open

Can we make NIOFoundationCompat depend on FoundationEssentials? #3038

t089 opened this issue Dec 26, 2024 · 1 comment

Comments

@t089
Copy link
Contributor

t089 commented Dec 26, 2024

Can we make NIOFoundationCompat only depend on FoundationEssentials?

Currently, unfortunately, I don't think we can as it provides convenience methods for types that are only available in full Foundation:

  • JSONSerialization
  • RunLoop

:( Would we need a NIOEssentialsCompat?
@Lukasa
Copy link
Contributor

Lukasa commented Dec 27, 2024

Essentially we can’t, because of the way Swift module imports leak. Until all those leaks are plugged, it is just not possible for us to ever remove an import without a semver major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t089 @Lukasa