Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to try several mirrors for a given registry #2274

Open
sathieu opened this issue Oct 2, 2024 · 7 comments
Open

Allow to try several mirrors for a given registry #2274

sathieu opened this issue Oct 2, 2024 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sathieu
Copy link

sathieu commented Oct 2, 2024

We use different mirrors and this works correctly with containerd which tries them in order and use the first working one (i.e. not 404 or other errors).

We need the same feature for trivy-operator.

This may require feature addition in trivy itself.

@sathieu sathieu added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Dec 2, 2024
@afdesk
Copy link
Contributor

afdesk commented Dec 2, 2024

@sathieu thanks for the idea.
Could you confirm it's still relevant for the latest trivy-operator with trivy v0.57.1?
please, if so feel free to reopen the issue.
thanks

@afdesk afdesk closed this as completed Dec 2, 2024
@sathieu
Copy link
Author

sathieu commented Dec 3, 2024

@afdesk I confirm that this is still relevant with trivy operator 0.22 and trivy 0.57.

@afdesk afdesk removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Dec 5, 2024
@afdesk
Copy link
Contributor

afdesk commented Dec 5, 2024

@afdesk I confirm that this is still relevant with trivy operator 0.22 and trivy 0.57.

@sathieu thanks! then we should reopen the issue, right?

@afdesk afdesk reopened this Dec 5, 2024
@afdesk
Copy link
Contributor

afdesk commented Dec 5, 2024

@sathieu
or did you test v0.22? v0.22 uses old Trivy
or is it a typo?

@sathieu
Copy link
Author

sathieu commented Dec 5, 2024

We use renovate to update versions, and so this is really trivy operator 0.22 and trivy 0.57.

Also, and didn't find any change related to this feature in the changelogs.

@afdesk
Copy link
Contributor

afdesk commented Dec 12, 2024

@sathieu you're right!
this feature should be added in the next Trivy release aquasecurity/trivy#7966
and then we'll update it in trivy-operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants