-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last.fm support #138
Comments
Depending on how the It is not required, but we should take care of #124 before this. |
If that's okay, I'd like to start looking into this issue @aquelemiguel. |
@afonsojramos Sure. |
I don't know if any progress had been made, but I started working on this feature in a separate fork Currently it's scrobbling the played track for users listening to it and with their Last.fm account registered in the bot I'm not sure how and when to trigger the scrobbling. It should be 30 seconds into a track, so a delayed event would do, but things like pausing/resuming the track or ending the track sooner would have to be taken into account |
I'll pass on the torch to you then @Educorreia932! Why do you say "It should be 30 seconds into a track"? On Spotify it starts tracking as soon as I skip into the song 🤔 |
Apparently the conditions to scrobble a track are slightly different. According to Last.fm documentation:
Although, these are just guidelines, nothing prevents the track from being scrobbled as soon as the track is played. |
For an initial implementation we can focus on implementing just the start listening and ignoring the pausing of tracks (assuming that Last.FM finishes the track after its full duration). |
There is a problem. To scrobble a track, both artist and title are required, although I don't know if currently we have that information when playing from YouTube |
That is, indeed, the source of the issue with this. Not everything that plays is music, and when it is music, the music might not even exist on Last.FM. So some parsing will need to be made to figure out the artist and match it to the artist on LastFM. |
/lastfm register
command to allow Parrot to automatically scrobble for this userThe text was updated successfully, but these errors were encountered: