Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No data returned at all #139

Open
sebelk opened this issue Dec 25, 2018 · 7 comments
Open

No data returned at all #139

sebelk opened this issue Dec 25, 2018 · 7 comments

Comments

@sebelk
Copy link

sebelk commented Dec 25, 2018

Hi, I'm using soccer-cli (0.1.0.0) and it returns no data, for example:

$ soccer --players --team=BM
No data for the team. Please check the team code.

No standings, no players, nothing at all. Is this project alive?

The python version is 3.6.7

Thanks in advance

@sebelk sebelk changed the title No data returned No data returned at all Dec 25, 2018
@Saturn
Copy link
Collaborator

Saturn commented Jan 1, 2019

You should still be able to get some data.

Although, the data source changed its API which is why if you try to get standings for the English Premier League for example, you will get data from last season (2017/2018).

The code would need to be adjusted to support the new API. As well as potentially updated to support the various access tiers which include support for different leagues/statistics etc.

https://www.football-data.org/documentation/api

@tiktuk
Copy link
Contributor

tiktuk commented Jan 14, 2019

I don't get any data returned either.

$ soccer --standings --league=EPL
No standings availble for EPL.

@Saturn
Copy link
Collaborator

Saturn commented Jan 14, 2019

Okay, it seems like the old v1 api url no longer returns the "old" data either.

The new api is structurally a little different so it isn't totally simple to change over.

I will have a closer look soon.

Thanks,

@Saturn
Copy link
Collaborator

Saturn commented Jan 14, 2019

@tiktuk @sebelk I have updated most of the commands to work with the new version of the api. 7fdabcf

Are you able to get data back now?

@tiktuk
Copy link
Contributor

tiktuk commented Jan 14, 2019

Yes, thanks, it looks good ☺️ !

@dfrt82
Copy link
Collaborator

dfrt82 commented Jan 15, 2019

Okay, it seems like the old v1 api url no longer returns the "old" data either.

Yes that's correct. v1 was shut down last week, but it was announced in July and December that it will be shut down to the end of 2018...

The new api is structurally a little different so it isn't totally simple to change over.

Yes, but just a little :-) Major enhancement are the fixed league codes, so now there's no need to touch the code for the new season any more.

@Saturn
Copy link
Collaborator

Saturn commented Jan 15, 2019

Thank you @dfrt82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants