Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Feedback #20

Open
10 of 12 tasks
gauravcusp opened this issue Feb 3, 2018 · 17 comments
Open
10 of 12 tasks

API Feedback #20

gauravcusp opened this issue Feb 3, 2018 · 17 comments
Labels

Comments

@gauravcusp
Copy link
Collaborator

gauravcusp commented Feb 3, 2018

Feedback:

  • Add Google maps plugin to get the coordinates from the dropped pin
  • Remove trailing 0s from some of the IDs
  • Remove ObjectID
  • Add address option on UI and reverse geo-code it to get the coordinates
  • Update UI explanation
  • Add some more geographies for LA City. See here

Please feel free to add other comments here.

@patwater @vr00n @lingyielia @xd515

How to submit an issue?

  • Have you checked previously open/closed issues to see if your question has already been asked & addressed?
    • If there is an open issue similar to your issue. Comment on that open issue with additional detail indicating that you too are having the same issue. This allows the project sponsor to prioritize incoming issues.
  • Have you provided a clear description of your issue so that the project sponsor is able to answer all your questions with as few back-n-forths as possible?
  • (Please acknowledge by checking this box) If a screenshot or visual helps better communicate some complex idea, have you provided one?. Draw.io and lucidchart are some excellent and quick drawing tools.
  • (Please acknowledge by checking this box) When an issue is resolved, please post the steps to resolution or clearly describe the resolution before marking the issue closed.
    • This will help future SOLVERS read through how your issue was solved and may help them solve their issue quicker.
  • Have you been kind, courteous, and considerate in your questions?
  • Have you considered using Stackedit.io, a handy tool to quickly write in markdown?
@vr00n
Copy link
Member

vr00n commented Feb 4, 2018

  • Update heading to generic "Geo CrossWalk of ....{x} - A single file that links up all the local geographies in {x}."

... or update it dynamically when you select a city "Los Angeles", "NYC"

@patwater
Copy link
Contributor

patwater commented Feb 5, 2018

I am getting:

"An error occurred in the application and your page could not be served. If you are the application owner, check your logs for details."

Looking at: https://calm-stream-52725.herokuapp.com/results?lonSearch=&latSearch=

:(

@gauravcusp
Copy link
Collaborator Author

Probably you're using a search query with empty parameters. Please try this link below and let us know if it works.
https://calm-stream-52725.herokuapp.com/

@patwater
Copy link
Contributor

patwater commented Feb 5, 2018

Oh you're right lol. For some reason I thought the defaults were inputted.

  • Also would be a nice feature improvement to be able to input an address in addition to a lat / long

What would be the way to query this API programmatically by the way?

@lingyielia
Copy link
Collaborator

lingyielia commented Feb 5, 2018

@patwater , sorry for this confusion.

  • Now you will get a notice if lon/lat input is Null.

@patwater
Copy link
Contributor

patwater commented Feb 5, 2018

Bravo! Also would be good to clarify the explanation text at the top.

"A single file that links up all the local geographies in one area."

->

Something like: "A Geo-Cross-Walk is a single file that provides a mapping between different boundaries in a given area. For example, in LA County this file provides the local city, legislative district, police precinct and other jurisdictions for a given lat / long."

@gauravcusp
Copy link
Collaborator Author

Thanks @patwater . I've added your suggestions to TO-DO list (the first comment of this thread).

@lingyielia lingyielia removed the bug label Feb 22, 2018
@gauravcusp
Copy link
Collaborator Author

@patwater @vr00n
we've figured out a way to geocode the physical address and extract coordinates from them so that the user won't have to look for coordinates. We'll deploy the code soon.

@patwater
Copy link
Contributor

Sweet please LMK when the update is available

@lingyielia
Copy link
Collaborator

@gauravcusp @vr00n @patwater
We've updated the UI. you can now use a human-readable address as input.

@patwater
Copy link
Contributor

Wow this is really amazing! One thing that strikes me as another future improvement. Some documentation on the different jurisdictions. For instance I'm not sure what Health District 47 / Northeast means and would be great to have a link to learn more. Relevant query: https://geocrosswalk.herokuapp.com/addr-results?place=la&physaddress=90042

@patwater
Copy link
Contributor

patwater commented Mar 26, 2018

Oh and one more thing. Could you please add "Powered by ARGO" somewhere on the app and link that to ARGOlabs.org ? Also please list your names and give yourselves credit?

argo logo

@vr00n vr00n mentioned this issue Mar 27, 2018
6 tasks
@patwater
Copy link
Contributor

patwater commented Apr 9, 2018

@gauravcusp I posted the blog post into the queue for the Open Knowledge Foundation: okfn/okfn.github.com#516

ARGO is their local chair for the first ever OKF US conference in Oakland in May. Could you please add "powered by ARGO" somewhere subtly on the API?

@gauravcusp
Copy link
Collaborator Author

Thanks @patwater ! We're excited about the blog 😄 We can make the changes on the UI but not sure if that can go on API as API data is fetched directly from DB.

@vr00n
Copy link
Member

vr00n commented Apr 10, 2018

@patwater lets try and avoid piling on the same issue. If this issue is done - lets close and create new ones for distinct tasks. Thanks

@patwater
Copy link
Contributor

@gauravcusp sounds good and agree about putting that in the documentation rather than the API. Please do add the ARGO logo though. Feel free to close this issue per V's comment if cleaner

@patwater
Copy link
Contributor

patwater commented Nov 5, 2018

@gauravcusp the API appears to be up though times out and says to check the logs. Who has the creds there. @gauravcusp ? @vr00n ?

screen shot 2018-11-05 at 8 11 08 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants