Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Secret Updates in Argo CD from Vault without Manual Deletion #682

Open
presotto-m opened this issue Nov 26, 2024 · 4 comments
Open

Comments

@presotto-m
Copy link

Is your feature request related to a problem? Please describe.
I'm experiencing an issue when updating a secret in Vault. Argo CD doesn't automatically detect the change. The update is only applied if I manually delete the old secret and run a sync in Argo CD, forcing it to recreate the secret and fetch the updated information from Vault.

Describe the solution you'd like
I would like Argo CD to automatically detect changes to secrets stored in Vault and apply the updates without the need for manual deletion and synchronization.

Describe alternatives you've considered
One alternative would be to use a webhook, similar to the one already used to listen for changes in GitHub. This webhook could be configured to monitor changes in Vault secrets and trigger an automatic update in Argo CD whenever a modification is detected.

Additional context
Currently, the manual process of deletion and synchronization delays the application of important updates and increases the risk of inconsistencies. Automation for this process would be ideal.

@bbetter173
Copy link

I'm not overly familiar with the plugin but I did notice that the docs have this to say:

If you want to load in a new value from your Secret Manager without making any new code changes you must use the Hard-Refresh concept in Argo CD. This can be done in two ways. You can either use the UI and select the Hard Refresh button which is located within the Refresh Button.

Source: https://argocd-vault-plugin.readthedocs.io/en/stable/usage/#refreshing-values-from-secrets-managers

@pre
Copy link

pre commented Dec 17, 2024

We are performing the ArgoCD Application > Hard Refresh whenever we need to refresh the value from Vault immediately.

There is no need to delete any resources. A webhook couldn't suit our usecase because we don't have any mapping in our repository of which ArgoCD Application(s) should be updated when a value in Vault is changed.

@ygormutti
Copy link

It would be nice to have a webhook or some kind of integration when updating secrets in Vault, because not necessarily the people who maintain the secrets on Vault are not the same that maintain the Kubernetes infra.

@pre
Copy link

pre commented Dec 25, 2024

The mechanism to get from ”Vault key X changed” to ”refresh Application A but not any other Applications” is unclear to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants