You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure what your procedure for API changing is (whether you just rename/remove elements, since this is pre 1.0 or not), but the "margins" option should be called "margin", as it is affecting the "margin-top", OR "margin-right", etc. (otherwise, it would be more appropriate for "margins" to be an array if it affected several margins -- though even that would be iffy, as we could simply check for if this.options.margin is an array or string, etc. and respond appropriately.)
I'm leaving "margins" as an option right now, and simply creating another option called "margin", and setting this.margin = this.margins if the "margins" option has been set. I'll leave the complete removal of "margins" up to you, since it is your project. This change along with some other fixes will be bundled in my pull request later today.
The text was updated successfully, but these errors were encountered:
I'm not sure what your procedure for API changing is (whether you just rename/remove elements, since this is pre 1.0 or not), but the "margins" option should be called "margin", as it is affecting the "margin-top", OR "margin-right", etc. (otherwise, it would be more appropriate for "margins" to be an array if it affected several margins -- though even that would be iffy, as we could simply check for if this.options.margin is an array or string, etc. and respond appropriately.)
I'm leaving "margins" as an option right now, and simply creating another option called "margin", and setting this.margin = this.margins if the "margins" option has been set. I'll leave the complete removal of "margins" up to you, since it is your project. This change along with some other fixes will be bundled in my pull request later today.
The text was updated successfully, but these errors were encountered: