Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Google Search clears title after extension changes it #530

Open
arimgibson opened this issue Oct 2, 2022 · 0 comments
Open

Bug: Google Search clears title after extension changes it #530

arimgibson opened this issue Oct 2, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@arimgibson
Copy link
Owner

Only present on the branch for v2.0.0. Can be debugged by adding a mutation observer into the onMessage listener in the content script, and then tracing the ridiculously long call stack. Not a priority but might be worth revisiting. Also possible that this bug is so minor that it's marked wontfix as the hassle to solve doesn't justify the benefit to the end user

chrome.runtime.onMessage.addListener(async (message: MessageToTab) => {
  if (message.status === 'updated') {
    const observer = new MutationObserver((mutations) => {
      mutations.forEach((mutation) => {
        console.log(mutation); // breakpoint here to view call stack
      });
    });
    observer.observe(document.querySelector('title'), { childList: true });

    setStyle(document);
    walk(document);
  }
});
@arimgibson arimgibson added the bug Something isn't working label Oct 2, 2022
@arimgibson arimgibson self-assigned this Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant