Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: defer connecting to gate client until necessary #44

Open
dpkirchner opened this issue Mar 17, 2020 · 0 comments · May be fixed by #45
Open

Feature Request: defer connecting to gate client until necessary #44

dpkirchner opened this issue Mar 17, 2020 · 0 comments · May be fixed by #45

Comments

@dpkirchner
Copy link

While bootstrapping a new project that defines some spinnaker resources, you will see errors when the spinnaker provider initializes during a plan. That's because it tries to connect immediately, before spinnaker has been installed. This means you have to comment out all of the spinnaker provider+resources before you can begin.

IMO, it'd be useful to defer the connection until the resource is about to be created. An error will likely still occur as the provider may not be able to connect to the server (it takes a while for spinnaker to start), but at least the plan and apply-sans-spinnaker steps will run.

I'll submit a PR for this shortly. I've been using it for about a week while destroying/recreating my projects and other than the above mentioned error it works fine.

@dpkirchner dpkirchner linked a pull request Mar 17, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant