-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a dedicated table in the user guide for intrinsic attributes #480
Comments
See also #481 |
Can you confirm my interpretation of "instrinsic attribute" please: so it includes all attributes that affect the processing. The full list is then: Also, are "set" and "defined" synonyms? |
I think the user manual is creating some confusion here. I would described this example more as "intrinsic behavior" and thus a separate topic. Intrinsic attributes are simply attributes that are defined by default that you can reference using the |
Yes. Feel free to make it consistent by choosing one or the other. |
Exactly. We need to be careful to talk about that in a separate section. Whenever we talk about an attribute that can be reference using |
Committed as 9940616. |
Amazing work @rockyallen! I was able to come in and add detail where it was missing, but you made it easy. We are still missing a few attributes.
I'm pretty confident that all the remaining attributes (at least for the built-in converters). |
Here's the attributes appendix as it now stands. http://asciidoctor.org/docs/user-manual/#builtin-predefined-attributes I think we should move the intrinsic attributes to this appendix too so that all the document attributes are together. wdyt? In the process, we've coined the following terms to differentiate the various attributes:
Does that sound right to you? What do you think we should call this appendix to encapsulate that list? cc: @jaredmorgs |
I'd just like to say thank you @rockyallen for finally making this happen. Not only is this appendix going to help just about every user of Asciidoctor, it also gives me a clarity I didn't have before. |
Two more:
|
No problem-and thanks for clearing up my mess. One day I will work out how to use Git... |
You're not the only one who had problems with this. 😉 Great job with your contributions! On Sat, 27 Feb 2016, 03:57 rockyallen [email protected] wrote:
Sent from Mobile. |
It's just a matter of documenting how to do it. This experience is helping me understand how to explain it. |
I'm also open to using "implicit" instead of "intrinsic". These two words are pretty close in meaning and it all depends on how you read it. |
Happy to add the extras listed above, but could someone reopen this issue please? I don't think I can. Re 'intrinsic': the definition above is "dynamic attributes that pertain to or give information about the runtime environment". The active words are 'information', 'runtime' and 'environment'. How about one of those, maybe runtime? Re the appendix title: Just "Attributes", or "Attribute definitions"? Side issue: |
I like "user-defined attributes" the best. |
How about something like "Attribute catalog", "Attribute index", "Attribute glossary" or "Attribute reference tables"? |
I had a discussion with @graphitefriction and we concluded that the most fitting name for the attributes that get automatically assigned based on the conditions under which the document is processed are "Environment attributes". environment - the aggregate of surrounding things, conditions, or influences I think it's a perfect fit and it is also a familiar concept/term for technical people. |
Under that definition, I think that Btw, I am intentionally avoiding the use of the word "variable". Technically, attributes are variables, but in AsciiDoc world we call "variables" attributes and therefore should remain consistent. |
resolves issue #480 more attributes
I can't believe it, we almost have all the attributes documented! I have a few I'm going to add to the intrinsic (soon to be environment) table and then I think we'll have them all. One issue that remains is that we'll need to document the EPUB3 and PDF attributes. I think it makes sense to add a new subsection in the table for each of these two converters (just below HTML styling). |
In that spirit, I think we should move all the manpage attributes (except manname-title) to a dedicated section for "Manpage" (in some cases, the attribute pertains to the manpage doctype and in other cases to the manpage converter, but I think it's reasonable to group them). |
We might also want to think about creating a group for section-related attributes since there are quite a few of those:
wdyt? |
Maybe, but if we carry on grouping at finer levels won't we end up just I don't know if it is possible to use it with Asciidoctor, but I really On 28/02/16 00:24, Dan Allen wrote:
|
I think there is definitely a risk of using too many categories, but keep in mind that the value of this table is that all the information is in one place. I think the key with the categories is to try to keep the groups balanced. The control/formatting group is too large atm, which is why I think moving the man attributes and the section attributes to their own category strikes the right balance. I'm going to give it a try and see how it feels. If it seems like too much, we can always roll back.
Me too. I've been thinking about adding that to Asciidoctor ever since I started working on it. We could add it as an extension to the user manual so it's available sooner rather than later. Interesting to note that it is implemented in docgist. See http://neo4j.com/graphgist/8e1d6ff9-f7fa-4c99-9c5d-ecb94ba46d81. |
To clarify why this issue is still open, we want to:
|
We're also still missing a few attributes:
I'm happy to add entries for these. The good news is that I can't find any more attributes that aren't mentioned. We're almost there!!
|
I'm keen on getting these two changes made:
Shall I open a separate issue and close this one @rockyallen? |
Sorry, got distracted-I will do it tonight.
|
See PR |
Resolves issue #480 table of attributes
Thanks @rockyallen! I added an intro to the Attribute Catalog and also revised the description of the Environment Attributes a bit. You can see the result here: http://asciidoctor.org/docs/user-manual/#attribute-catalog The only think left in this issue is to document the doctitle and title attributes. I'll take care of that next. |
At last, we're done! http://asciidoctor.org/docs/user-manual/#attribute-catalog From this point forward, we'll address any improvements to the entries in these tables through dedicated issues. Great work team! @rockyallen @jaredmorgs |
@rockyallen are you on Twitter by chance? I like to give contributors a shout out there to help promote their great work. |
Thats very kind, but I'm a bit of dinosaur - I don't even have a mobile On 15/03/16 21:58, Dan Allen wrote:
|
I'm very glad you're involved! I just wanted to be sure I wasn't missing you on Twitter. To fill you in, I posted the following two messages related to this issue:
&
|
Ever since you started contributing to the docs, I've wondered what the Was it the links to all the bug IDs in the User Guide that made you open Either way, I'm so glad you're here lending your skills to the project. It's fantastic!Sent from Mobile. |
Answers to these questions could help us lower barriers for contributors, improve the workflow and provide necessary guidance and motivation. In other words, we want to do whatever we can to pique the interest of those that want to be involved. |
(blushes) You all do a great job on a great bit of software. I use it for my day job, and I wanted to give something back. I tried contributing to the code but learning a new language was a bit much for me; writing is easy, especially when Asciidoctor has such a good documentation set already. Re the pointers - yes they are a prompt to areas that need input, but mostly I chose areas that were giving trouble at work - documenting being a good way to learn. The biggest barrier to contributing for me was Git/GitHub which I found (find!) very challenging. Do you think there is a way to to simplify it, or give more hand-holding for newbies? Thanks Rocky |
Thanks to you, the documentation set is drastically improving, not to mention more complete. We can all be proud of that. From your feedback, it seems like the most valuable tool is a link from the documentation to an open issue. That supports the case that you are reading the documentation for your own needs and you get prompted where you can jump in to help. In other words, it flags where paths cross and gives a next action.
That's the million dollar question. I love git & GitHub because it gives us a powerful workspace in which to collaborate. However, there are still some incredibly sharp edges that present a big challenge, for writing especially. I think the solution here is provide a very clear and well-written contributing guide for writers (see #468 and #403). When I think about how I work, there are just a few techniques I use over and over without ever running into problems. I am far, far, far from a git master. It's just that I know exactly what everyday commands to issue so that I avoid getting hung up. The key is to figure out how to describe those techniques so that anyone coming along can follow them. (how to work with branches, when to use amend, when to use rebase, how to fast-forward merge to master, send a pull request to another pull request, etc). It's going to be a fun challenge. Beyond that, there is a chance a tool will come along that works on top of GitHub that hides a lot of this away. But I have yet to find such a tool. |
And, once again, thank you Rocky! |
Add an extra table in Appendix B so that eventually all available attributes can be found there. I would also suggest renaming Appendix B to "Predefined Attributes" to make this clear.
The text was updated successfully, but these errors were encountered: